mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Cc: Javier Martinez Canillas <javier@dowhile0.org>,
	Tomasz Figa <tomasz.figa@gmail.com>,
	Doug Anderson <dianders@chromium.org>,
	Olof Johansson <olof@lixom.net>,
	Yuvaraj Kumar C D <yuvaraj.cd@gmail.com>,
	"linux-samsung-soc@vger.kernel.org" 
	<linux-samsung-soc@vger.kernel.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] regulator: max77802: set opmode to normal if off is read from hw
Date: Thu, 28 Aug 2014 11:01:55 +0100	[thread overview]
Message-ID: <20140828100155.GK17528@sirena.org.uk> (raw)
In-Reply-To: <12F88867-EF9E-4BCA-9209-6879A39F3DEA@collabora.co.uk>

[-- Attachment #1: Type: text/plain, Size: 986 bytes --]

On Thu, Aug 28, 2014 at 11:59:16AM +0200, Javier Martinez Canillas wrote:
> > On 28/08/2014, at 10:28, Mark Brown <broonie@kernel.org> wrote:

> >> Yes, AFAIK the bootloader (none of them because Chromebooks use two
> >> chained U-boots) change the regulators default opmode so once is set
> >> to OFF on .disable, that value is preserved on warm reboot. This made
> >> sense with the Chrome OS kernel since the kernel always set the opmode
> >> defined in the "regulator-op-mode" DT property and did not relied on
> >> the bootloader to set the most efficient default opmode.

> > I'm sorry but this is just really unclear.  Does the bootloader change
> > the mode or does it not change the mode?

> I meant that the boot loader *does not* change the mode and is Linux
> who change it, sorry for the confusion.

Ah, OK.  Like I say that's a separate concern to the one Tomasz was
raising - he is worried about the case where we change the mode in the
bootloader but only on cold boot.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2014-08-28 10:02 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-26 11:37 Javier Martinez Canillas
2014-08-26 15:44 ` Doug Anderson
2014-08-27  6:47 ` Yuvaraj Kumar
2014-08-27 17:51 ` Mark Brown
2014-08-27 18:32 ` Tomasz Figa
2014-08-27 18:37   ` Mark Brown
2014-08-27 18:39     ` Tomasz Figa
2014-08-27 18:47       ` Mark Brown
2014-08-27 18:52         ` Tomasz Figa
2014-08-27 19:15           ` Mark Brown
2014-08-27 19:21             ` Tomasz Figa
2014-08-27 19:44               ` Mark Brown
2014-08-27 19:58                 ` Tomasz Figa
2014-08-27 20:25                   ` Mark Brown
2014-08-27 20:41                     ` Tomasz Figa
2014-08-27 21:03                       ` Tomasz Figa
2014-08-27 22:44                         ` Javier Martinez Canillas
2014-08-28  8:28                           ` Mark Brown
2014-08-28  9:59                             ` Javier Martinez Canillas
2014-08-28 10:01                               ` Mark Brown [this message]
2014-08-27 21:03                       ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140828100155.GK17528@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=dianders@chromium.org \
    --cc=javier.martinez@collabora.co.uk \
    --cc=javier@dowhile0.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=tomasz.figa@gmail.com \
    --cc=yuvaraj.cd@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®