From: Alexander Gordeev <agordeev@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Tadeusz Struk <tadeusz.struk@intel.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
qat-linux@intel.com, linux-crypto@vger.kernel.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH] crypto: qat - Use pci_enable_msix_exact() instead of pci_enable_msix()
Date: Fri, 29 Aug 2014 10:10:55 +0100 [thread overview]
Message-ID: <20140829091055.GA1035@agordeev.usersys.redhat.com> (raw)
In-Reply-To: <1408433524-11487-1-git-send-email-agordeev@redhat.com>
On Tue, Aug 19, 2014 at 09:32:04AM +0200, Alexander Gordeev wrote:
> As result of deprecation of MSI-X/MSI enablement functions
> pci_enable_msix() and pci_enable_msi_block() all drivers
> using these two interfaces need to be updated to use the
> new pci_enable_msi_range() or pci_enable_msi_exact()
> and pci_enable_msix_range() or pci_enable_msix_exact()
> interfaces.
Hello Gentleman,
This trivial patch blocks phasing out of deprecated
pci_enable_msix() function. Could someone review and
accept it, please?
Thanks!
> Cc: Tadeusz Struk <tadeusz.struk@intel.com>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: qat-linux@intel.com
> Cc: linux-crypto@vger.kernel.org
> Cc: linux-pci@vger.kernel.org
> Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
> ---
> drivers/crypto/qat/qat_dh895xcc/adf_isr.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/crypto/qat/qat_dh895xcc/adf_isr.c b/drivers/crypto/qat/qat_dh895xcc/adf_isr.c
> index d4172de..1082e3b 100644
> --- a/drivers/crypto/qat/qat_dh895xcc/adf_isr.c
> +++ b/drivers/crypto/qat/qat_dh895xcc/adf_isr.c
> @@ -70,9 +70,9 @@ static int adf_enable_msix(struct adf_accel_dev *accel_dev)
> for (i = 0; i < msix_num_entries; i++)
> pci_dev_info->msix_entries.entries[i].entry = i;
>
> - if (pci_enable_msix(pci_dev_info->pci_dev,
> - pci_dev_info->msix_entries.entries,
> - msix_num_entries)) {
> + if (pci_enable_msix_exact(pci_dev_info->pci_dev,
> + pci_dev_info->msix_entries.entries,
> + msix_num_entries)) {
> pr_err("QAT: Failed to enable MSIX IRQ\n");
> return -EFAULT;
> }
> --
> 1.9.3
>
--
Regards,
Alexander Gordeev
agordeev@redhat.com
next prev parent reply other threads:[~2014-08-29 9:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-19 7:32 Alexander Gordeev
2014-08-29 9:10 ` Alexander Gordeev [this message]
2014-08-29 13:48 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140829091055.GA1035@agordeev.usersys.redhat.com \
--to=agordeev@redhat.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=qat-linux@intel.com \
--cc=tadeusz.struk@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®