From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753202AbaH2NDg (ORCPT ); Fri, 29 Aug 2014 09:03:36 -0400 Received: from demumfd002.nsn-inter.net ([93.183.12.31]:34458 "EHLO demumfd002.nsn-inter.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752735AbaH2NDe (ORCPT ); Fri, 29 Aug 2014 09:03:34 -0400 Date: Fri, 29 Aug 2014 17:06:56 +0300 From: Matti Vaittinen To: ext Jason Cooper Cc: Mark Rutland , ext Guenter Roeck , "a.zummo@towertech.it" , "jic23@kernel.org" , "arno@natisbad.org" , "jgunthorpe@obsidianresearch.com" , "san@rosetechnology.dk" , "hs@denx.de" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "rtc-linux@googlegroups.com" , Sverdlin Alexander Subject: Re: [PATCH] rtc: ds1307: add trickle charger device tree binding Message-ID: <20140829140656.GC13630@fi-ourus-dhcp00977.emea.nsn-net.net> References: <20140828155157.GB23677@roeck-us.net> <20140828161025.GO14650@leverpostej> <20140828164825.GA12153@roeck-us.net> <20140828172842.GF12769@titan.lakedaemon.net> <20140828174034.GC15307@roeck-us.net> <20140829073413.GN4587@fi-ourus-dhcp00977.emea.nsn-net.net> <20140829104001.GB19424@leverpostej> <20140829122452.GA3683@titan.lakedaemon.net> <20140829124216.GD21473@leverpostej> <20140829124829.GD3683@titan.lakedaemon.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140829124829.GD3683@titan.lakedaemon.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-purgate-type: clean X-purgate-Ad: Categorized by eleven eXpurgate (R) http://www.eleven.de X-purgate: clean X-purgate: This mail is considered clean (visit http://www.eleven.de for further information) X-purgate-size: 1839 X-purgate-ID: 151667::1409317347-000023E0-C377EC5F/0/0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 29, 2014 at 08:48:29AM -0400, ext Jason Cooper wrote: > On Fri, Aug 29, 2014 at 01:42:16PM +0100, Mark Rutland wrote: > > On Fri, Aug 29, 2014 at 01:24:52PM +0100, Jason Cooper wrote: > > > On Fri, Aug 29, 2014 at 11:40:02AM +0100, Mark Rutland wrote: > ... > Someone wrote: > > > > > > > > http://datasheets.maximintegrated.com/en/ds/DS1307.pdf > > > > > > > > http://datasheets.maximintegrated.com/en/ds/DS1337.pdf > > > > > > > > http://datasheets.maximintegrated.com/en/ds/DS1338.pdf > > > > > > > > http://datasheets.maximintegrated.com/en/ds/DS1339.pdf > > > > > > > > http://datasheets.maximintegrated.com/en/ds/DS1340.pdf > > > > > > > > http://datasheets.maximintegrated.com/en/ds/DS1388.pdf > > > > > > > > http://datasheets.maximintegrated.com/en/ds/DS3231.pdf > ... > > > > I would suggest we have two properties that describe the resistor's > > > > rating and whether or not there is a diode: > > > > > > > > trickle-resistor-ohms = <250> > > > > diode-connected; > > > > > > I much prefer this solution over my own suggestion. With one small > > > change, s/diode-connected/trickle-diode-enable/ Does that sound ok? > > > > I'm not too keen on 'enable'; I was under the impression that this > > described whether or not there was an external diode. Perhaps I've > > misunderstood? > > iiuc from the link ds1339 ds, the register configuration is enabling > internal diodes and resistors for the trickle charge configuration. I > may have read it incorrectly, though. Yes. It is about using internal diode. I will cook new patch based on these comments on monday. Regards Matti Vaittinen -- ============================================= Matti Vaittinen Senile SW Specialist FINLAND ~~ When things go utterly wrong vim users can always type :help! ~~