From: Mark Brown <broonie@kernel.org>
To: Dmitry Eremin-Solenikov <dmitry_eremin@mentor.com>
Cc: linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
Dirk Behme <dirk.behme@de.bosch.com>,
Gokulkrishnan Nagarajan <Gokulkrishnan.Nagarajan@in.bosch.com>
Subject: Re: [PATCH] regulator: core: GPIO #0 is a valid GPIO
Date: Fri, 29 Aug 2014 20:01:29 +0100 [thread overview]
Message-ID: <20140829190129.GZ29327@sirena.org.uk> (raw)
In-Reply-To: <1409336356-27682-1-git-send-email-dmitry_eremin@mentor.com>
[-- Attachment #1: Type: text/plain, Size: 982 bytes --]
On Fri, Aug 29, 2014 at 10:19:16PM +0400, Dmitry Eremin-Solenikov wrote:
> From: Dirk Behme <dirk.behme@de.bosch.com>
>
> With GPIO #0, this if statement will always fail. Remove this, the
> check for gpio_is_valid() is sufficent here.
No, read the archives - this will break boards using zero as default.
Any current boards should be using DT and so shouldn't be using fixed
GPIO numbers in the first place which will mean they'll not end up
getting zero as a valid GPIO. If you are using zero as a GPIO for some
reason provide a way to specify that the GPIO is a real GPIO and not
just the default value for the struct.
> Change-Id: Ia10e8e9c74e11deba852fcd44040cc275b583cfd
> Signed-off-by: Gokulkrishnan Nagarajan <Gokulkrishnan.Nagarajan@in.bosch.com>
> Signed-off-by: Dirk Behme <dirk.behme@de.bosch.com>
In any case I can't apply this since you didn't sign it off and please
don't include noise from your internal review system in upstream
postings.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-08-29 19:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-29 18:19 Dmitry Eremin-Solenikov
2014-08-29 19:01 ` Mark Brown [this message]
2014-09-01 7:46 ` Dirk Behme
2014-09-01 7:55 ` Geert Uytterhoeven
2014-09-01 10:15 ` Mark Brown
2014-09-01 11:59 ` Dmitry Eremin-Solenikov
2014-09-01 12:06 ` Mark Brown
2014-09-01 12:35 ` Dmitry Eremin-Solenikov
2014-09-01 12:49 ` Mark Brown
2014-09-03 9:04 ` Dmitry Eremin-Solenikov
2014-09-03 11:01 ` Mark Brown
2014-09-04 17:15 ` Linus Walleij
2014-09-04 17:19 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140829190129.GZ29327@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Gokulkrishnan.Nagarajan@in.bosch.com \
--cc=dirk.behme@de.bosch.com \
--cc=dmitry_eremin@mentor.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®