From: David Miller <davem@davemloft.net>
To: harish_kandiga@mentor.com
Cc: dborkman@redhat.com, tgraf@suug.ch, ebiederm@xmission.com,
darkjames-ws@darkjames.pl, rgb@redhat.com,
eric.dumazet@gmail.com, stephen@networkplumber.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] netlink: Safer deletion of sk_bind_node
Date: Tue, 02 Sep 2014 22:28:19 -0700 (PDT) [thread overview]
Message-ID: <20140902.222819.1246875721008896036.davem@davemloft.net> (raw)
In-Reply-To: <5406A4FF.1090209@mentor.com>
From: Harish Jenny Kandiga Nagaraj <harish_kandiga@mentor.com>
Date: Wed, 3 Sep 2014 10:49:59 +0530
> If that is the case , then subscriptions of netlink_sock should have
> been updated after netlink_remove or netlink_release. I don't see
> that happening.
Please do not top-post. First provide the quoted context, then provide
your response afterwards, rather than the other way around.
The point I was trying to make is that all code paths that operate
on this list have to follow this rule, if there is a code path that
is not then that is your bug and that is where the fix belongs.
We're unexpectedly having double deletes occur on this list, I would
prefer if we don't paper over it by allowing it to silently succeed.
prev parent reply other threads:[~2014-09-03 5:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-01 7:08 [PATCH] " Harish, Jenny, K, N
2014-09-02 1:12 ` Eric W. Biederman
2014-09-02 5:03 ` David Miller
2014-09-02 8:44 ` [RFC PATCH] " Harish Jenny Kandiga Nagaraj
2014-09-02 18:52 ` David Miller
2014-09-03 5:19 ` Harish Jenny Kandiga Nagaraj
2014-09-03 5:28 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140902.222819.1246875721008896036.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=darkjames-ws@darkjames.pl \
--cc=dborkman@redhat.com \
--cc=ebiederm@xmission.com \
--cc=eric.dumazet@gmail.com \
--cc=harish_kandiga@mentor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rgb@redhat.com \
--cc=stephen@networkplumber.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®