From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753408AbaIBJ4F (ORCPT ); Tue, 2 Sep 2014 05:56:05 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:57435 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752076AbaIBJ4A (ORCPT ); Tue, 2 Sep 2014 05:56:00 -0400 Date: Tue, 2 Sep 2014 11:55:53 +0200 From: Peter Zijlstra To: Guenter Roeck Cc: Stephen Rothwell , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Ingo Molnar , "David S. Miller" Subject: Re: linux-next: Tree for Aug 23 Message-ID: <20140902095553.GE31157@worktop.ger.corp.intel.com> References: <20140823080422.7895575c@canb.auug.org.au> <20140825045741.GA29723@roeck-us.net> <20140901155804.GT27892@worktop.ger.corp.intel.com> <5404A2F2.3090908@roeck-us.net> <20140901190438.GB5806@worktop.ger.corp.intel.com> <20140902094016.GD31157@worktop.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140902094016.GD31157@worktop.ger.corp.intel.com> User-Agent: Mutt/1.5.22.1 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 02, 2014 at 11:40:16AM +0200, Peter Zijlstra wrote: > On Mon, Sep 01, 2014 at 09:04:38PM +0200, Peter Zijlstra wrote: > > On Mon, Sep 01, 2014 at 09:46:42AM -0700, Guenter Roeck wrote: > > > Yes, the problem is still seen in next-140829. See qemu test results at > > > http://server.roeck-us.net:8010/builders. > > > > > > I provided sparc64 images at http://server.roeck-us.net/qemu/sparc64/. > > > The README file includes instructions on how to run the image in qemu > > > and how to build a kernel. > > > > > > I can do the same for mips and mips64 if needed; let me know. > > > > Thanks, that's enough to get started. > > This makes sparc64 go again, silly oversight indeed. > The same for mips. Can you either provide the mips image or verify this works? --- diff --git a/arch/mips/include/asm/atomic.h b/arch/mips/include/asm/atomic.h index 476fe3b..b3dd612 100644 --- a/arch/mips/include/asm/atomic.h +++ b/arch/mips/include/asm/atomic.h @@ -93,7 +93,7 @@ static __inline__ int atomic_##op##_return(int i, atomic_t * v) \ " " #asm_op " %0, %1, %3 \n" \ " sc %0, %2 \n" \ " beqzl %0, 1b \n" \ - " addu %0, %1, %3 \n" \ + " " #asm_op " %0, %1, %3 \n" \ " .set mips0 \n" \ : "=&r" (result), "=&r" (temp), "+m" (v->counter) \ : "Ir" (i)); \