From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754954AbaIBR5V (ORCPT ); Tue, 2 Sep 2014 13:57:21 -0400 Received: from mga11.intel.com ([192.55.52.93]:10555 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751739AbaIBR5U (ORCPT ); Tue, 2 Sep 2014 13:57:20 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="380420744" Date: Tue, 2 Sep 2014 10:57:18 -0700 From: Jacob Pan To: "Rafael J. Wysocki" Cc: Rafael Wysocki , Linux PM , Srinivas Pandruvada , LKML Subject: Re: [PATCH] powercap/rapl: lower warning level for domain detection Message-ID: <20140902105718.7e9ec107@ultegra> In-Reply-To: <2181254.mWuCKKqmQW@vostro.rjw.lan> References: <1409288168-6537-1-git-send-email-jacob.jun.pan@linux.intel.com> <2181254.mWuCKKqmQW@vostro.rjw.lan> Organization: OTC X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 02 Sep 2014 01:48:40 +0200 "Rafael J. Wysocki" wrote: > On Thursday, August 28, 2014 09:56:08 PM Jacob Pan wrote: > > Many CPUs do not support complete set of RAPL domains, as a > > result this detection failed message is very misleading and > > annoying. So loweab Pan > > What about printing a (info-level) message if the RAPL domain *is* > supported? That surely is more interesting? > yes, that is better. just sent out an updated patch with a different Subject: [PATCH] powercap/rapl: change domain detection message Thanks, Jacob > > --- > > drivers/powercap/intel_rapl.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/powercap/intel_rapl.c > > b/drivers/powercap/intel_rapl.c index b1cda6f..0b282e7 100644 > > --- a/drivers/powercap/intel_rapl.c > > +++ b/drivers/powercap/intel_rapl.c > > @@ -1169,7 +1169,7 @@ static int rapl_detect_domains(struct > > rapl_package *rp, int cpu) if (!rapl_check_domain(cpu, i)) > > rp->domain_map |= 1 << i; > > else > > - pr_warn("RAPL domain %s detection > > failed\n", > > + pr_info("RAPL domain %s not supported\n", > > rapl_domain_names[i]); > > } > > rp->nr_domains = bitmap_weight(&rp->domain_map, > > RAPL_DOMAIN_MAX); > > > [Jacob Pan]