From: Darren Hart <dvhart@infradead.org>
To: Matthew Garrett <matthew.garrett@nebula.com>
Cc: "benjamin.tissoires@redhat.com" <benjamin.tissoires@redhat.com>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] platform/x86: toshiba: re-enable acpi hotkeys after suspend to disk
Date: Tue, 2 Sep 2014 15:50:57 -0700 [thread overview]
Message-ID: <20140902225057.GB11195@vmdeb7> (raw)
In-Reply-To: <1409681238.11717.4.camel@nebula.com>
On Tue, Sep 02, 2014 at 06:07:19PM +0000, Matthew Garrett wrote:
> On Tue, 2014-09-02 at 14:04 -0400, Benjamin Tissoires wrote:
>
> > we noticed this problem on a Toshiba Z40. I kind of brute-forced the thing, and
> > I ended up that calling "ENAB" was making the keys working again (rmmod/insmod
> > the driver was sufficient, and the only command which was different from the
> > resume was this ACPI call).
> >
> > I am really surprised some toshiba laptops do not need this, so I'd prefer that
> > an ACPI expert (Matthew???) gives its wisdom regarding that.
>
> Looks good to me. I'd be surprised if this breaks anything.
>
> Acked-by: Matthew Garrett <matthew.garrett@nebula.com>
Queued. Thanks.
--
Darren Hart
Intel Open Source Technology Center
prev parent reply other threads:[~2014-09-02 22:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 18:04 Benjamin Tissoires
2014-09-02 18:07 ` Matthew Garrett
2014-09-02 22:50 ` Darren Hart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140902225057.GB11195@vmdeb7 \
--to=dvhart@infradead.org \
--cc=benjamin.tissoires@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.garrett@nebula.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®