From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Piotr Witoslawski <pwitos@gmail.com>
Cc: lidza.louina@gmail.com, driverdev-devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org, markh@compro.net
Subject: Re: [PATCH] drivers: staging: dgap: fix the checkpatch.pl issue "Warning: line over 80 characters"
Date: Wed, 3 Sep 2014 20:22:04 +0530 [thread overview]
Message-ID: <20140903145203.GB15176@sudip-PC> (raw)
In-Reply-To: <20140903140959.GA24601@pwitoslawski.warsaw.osa>
On Wed, Sep 03, 2014 at 04:09:59PM +0200, Piotr Witoslawski wrote:
> Done as Eudyptula task 10.
use proper commit message mentioning what changes you have done.
and you have not sent the patch to all the people who were
supposed to be sent.
thanks
sudip
> Signed-off-by: Piotr Witoslawski <pwitos@gmail.com>
> ---
> drivers/staging/dgap/dgap.c | 16 ++++++++++------
> 1 file changed, 10 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
> index 8929dbf..67da1d5 100644
> --- a/drivers/staging/dgap/dgap.c
> +++ b/drivers/staging/dgap/dgap.c
> @@ -88,7 +88,8 @@ static int dgap_block_til_ready(struct tty_struct *tty, struct file *file,
> struct channel_t *ch);
> static int dgap_tty_ioctl(struct tty_struct *tty, unsigned int cmd,
> unsigned long arg);
> -static int dgap_tty_digigeta(struct channel_t *ch, struct digi_t __user *retinfo);
> +static int dgap_tty_digigeta(struct channel_t *ch,
> + struct digi_t __user *retinfo);
> static int dgap_tty_digiseta(struct channel_t *ch, struct board_t *bd,
> struct un_t *un, struct digi_t __user *new_info);
> static int dgap_tty_digigetedelay(struct tty_struct *tty, int __user *retinfo);
> @@ -104,8 +105,9 @@ static void dgap_tty_flush_chars(struct tty_struct *tty);
> static void dgap_tty_flush_buffer(struct tty_struct *tty);
> static void dgap_tty_hangup(struct tty_struct *tty);
> static int dgap_wait_for_drain(struct tty_struct *tty);
> -static int dgap_set_modem_info(struct channel_t *ch, struct board_t *bd, struct un_t *un,
> - unsigned int command, unsigned int __user *value);
> +static int dgap_set_modem_info(struct channel_t *ch, struct board_t *bd,
> + struct un_t *un, unsigned int command,
> + unsigned int __user *value);
> static int dgap_get_modem_info(struct channel_t *ch,
> unsigned int __user *value);
> static int dgap_tty_digisetcustombaud(struct channel_t *ch, struct board_t *bd,
> @@ -3076,8 +3078,9 @@ static int dgap_get_modem_info(struct channel_t *ch, unsigned int __user *value)
> *
> * Set modem signals, called by ld.
> */
> -static int dgap_set_modem_info(struct channel_t *ch, struct board_t *bd, struct un_t *un,
> - unsigned int command, unsigned int __user *value)
> +static int dgap_set_modem_info(struct channel_t *ch, struct board_t *bd,
> + struct un_t *un, unsigned int command,
> + unsigned int __user *value)
> {
> int ret;
> unsigned int arg;
> @@ -3153,7 +3156,8 @@ static int dgap_set_modem_info(struct channel_t *ch, struct board_t *bd, struct
> *
> *
> */
> -static int dgap_tty_digigeta(struct channel_t *ch, struct digi_t __user *retinfo)
> +static int dgap_tty_digigeta(struct channel_t *ch,
> + struct digi_t __user *retinfo)
> {
> struct digi_t tmp;
> ulong lock_flags;
> --
> 1.8.5.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
prev parent reply other threads:[~2014-09-03 14:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-03 14:09 Piotr Witoslawski
2014-09-03 14:52 ` Sudip Mukherjee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140903145203.GB15176@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=lidza.louina@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markh@compro.net \
--cc=pwitos@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®