From: Peter Zijlstra <peterz@infradead.org>
To: Preeti U Murthy <preeti@linux.vnet.ibm.com>
Cc: Vincent Guittot <vincent.guittot@linaro.org>,
Ingo Molnar <mingo@kernel.org>, Rik van Riel <riel@redhat.com>,
Morten Rasmussen <Morten.Rasmussen@arm.com>,
LKML <linux-kernel@vger.kernel.org>,
Mike Galbraith <efault@gmx.de>,
Nicolas Pitre <nicolas.pitre@linaro.org>,
"daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Subject: Re: [QUERY] Confusing usage of rq->nr_running in load balancing
Date: Wed, 3 Sep 2014 17:30:11 +0200 [thread overview]
Message-ID: <20140903153011.GR4783@worktop.ger.corp.intel.com> (raw)
In-Reply-To: <540707D9.4040208@linux.vnet.ibm.com>
On Wed, Sep 03, 2014 at 05:51:45PM +0530, Preeti U Murthy wrote:
> Hi,
>
> There are places in kernel/sched/fair.c in the load balancing part where
> rq->nr_running is used as against cfs_rq->nr_running. At least I could
> Did I miss something or is it true that the usage of rq->nr_running in
> the above places is incorrect?
Yeah, smells fishy. Probably hysterical accidents that haven't been
cleaned up yet. I do remember a few patches cleaning some of this up
recently. Clearly there's more to do.
next prev parent reply other threads:[~2014-09-03 15:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-03 12:21 Preeti U Murthy
2014-09-03 15:30 ` Peter Zijlstra [this message]
2014-09-03 16:58 ` Vincent Guittot
2014-09-05 12:19 ` Preeti U Murthy
2014-09-05 12:27 ` Vincent Guittot
2014-09-10 8:21 ` Preeti U Murthy
2014-09-15 4:16 ` Preeti U Murthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140903153011.GR4783@worktop.ger.corp.intel.com \
--to=peterz@infradead.org \
--cc=Morten.Rasmussen@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=dietmar.eggemann@arm.com \
--cc=efault@gmx.de \
--cc=kamalesh@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=nicolas.pitre@linaro.org \
--cc=preeti@linux.vnet.ibm.com \
--cc=riel@redhat.com \
--cc=srikar@linux.vnet.ibm.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome