From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Seth Forshee <seth.forshee@canonical.com>,
linux-kernel@vger.kernel.org,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
luca@coelho.fi, kvalo@adurom.com
Subject: Re: [RFC] firmware coredump: add new firmware coredump class
Date: Wed, 3 Sep 2014 12:15:16 -0700 [thread overview]
Message-ID: <20140903191516.GB16582@kroah.com> (raw)
In-Reply-To: <1409770842.911.18.camel@jlt4.sipsolutions.net>
On Wed, Sep 03, 2014 at 09:00:42PM +0200, Johannes Berg wrote:
> On Wed, 2014-09-03 at 09:38 -0500, Seth Forshee wrote:
>
> > Overall I think this looks pretty sensible. The thing that worries me
> > though is firmware which might crash repeatedly in a short period of
> > time, resulting in a proliferation of coredumps and eating up all
> > available RAM. How about a limit of one active coredump per device or
> > something similar?
>
> Oh, right, I completely forgot about that. Not sure what context I can
> iterate the class device list, but worst case I have to add another
> list.
Before you add another device, walk the list of all devices of the class
to see if there is already a device with the same parent. If so, delete
that one and then continue and add the one you wanted to create.
> We likely want to store the first dump then, I suppose?
Or the last one? I don't know...
greg k-h
next prev parent reply other threads:[~2014-09-03 19:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-03 11:15 Johannes Berg
2014-09-03 14:19 ` Daniel Vetter
2014-09-03 19:05 ` Johannes Berg
2014-09-03 19:24 ` Daniel Vetter
2014-09-03 14:38 ` Seth Forshee
2014-09-03 19:00 ` Johannes Berg
2014-09-03 19:15 ` Greg Kroah-Hartman [this message]
2014-09-03 19:21 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140903191516.GB16582@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=daniel.vetter@ffwll.ch \
--cc=emmanuel.grumbach@intel.com \
--cc=johannes@sipsolutions.net \
--cc=kvalo@adurom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@coelho.fi \
--cc=seth.forshee@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®