From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753628AbaIDMtn (ORCPT <rfc822;w@1wt.eu>);
	Thu, 4 Sep 2014 08:49:43 -0400
Received: from mail-qc0-f170.google.com ([209.85.216.170]:63015 "EHLO
	mail-qc0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751182AbaIDMtl (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 4 Sep 2014 08:49:41 -0400
From: Jeff Layton <jeff.layton@primarydata.com>
X-Google-Original-From: Jeff Layton <jlayton@primarydata.com>
Date: Thu, 4 Sep 2014 08:49:38 -0400
To: Trond Myklebust <trond.myklebust@primarydata.com>
Cc: Devel FS Linux <linux-fsdevel@vger.kernel.org>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        Christoph Hellwig <hch@infradead.org>,
        "J. Bruce Fields" <bfields@fieldses.org>,
        Linux Kernel mailing list <linux-kernel@vger.kernel.org>,
        Steven Whitehouse <swhiteho@redhat.com>,
        cluster-devel <cluster-devel@redhat.com>
Subject: Re: [PATCH v2 01/17] locks: consolidate "nolease" routines
Message-ID: <20140904084938.2664bf0a@tlielax.poochiereds.net>
In-Reply-To: <CAHQdGtTqG8aW-cte2PW6pVw+OeCXATgr1BZwdhponuWMjzNg8g@mail.gmail.com>
References: <1409834323-7171-1-git-send-email-jlayton@primarydata.com>
	<1409834323-7171-2-git-send-email-jlayton@primarydata.com>
	<CAHQdGtTqG8aW-cte2PW6pVw+OeCXATgr1BZwdhponuWMjzNg8g@mail.gmail.com>
X-Mailer: Claws Mail 3.10.1 (GTK+ 2.24.22; x86_64-redhat-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 4 Sep 2014 08:41:51 -0400
Trond Myklebust <trond.myklebust@primarydata.com> wrote:

> On Thu, Sep 4, 2014 at 8:38 AM, Jeff Layton <jlayton@primarydata.com> wrote:
> > GFS2 and NFS have setlease routines that always just return -EINVAL.
> > Turn that into a generic routine that can live in fs/libfs.c.
> >
> > Cc: Trond Myklebust <trond.myklebust@primarydata.com>
> > Cc: <linux-nfs@vger.kernel.org>
> > Cc: Steven Whitehouse <swhiteho@redhat.com>
> > Cc: <cluster-devel@redhat.com>
> > Signed-off-by: Jeff Layton <jlayton@primarydata.com>
> > ---
> >  fs/gfs2/file.c     | 22 +---------------------
> >  fs/libfs.c         | 16 ++++++++++++++++
> >  fs/nfs/file.c      | 13 +------------
> >  fs/nfs/internal.h  |  1 -
> >  fs/nfs/nfs4file.c  |  2 +-
> >  include/linux/fs.h |  1 +
> >  6 files changed, 20 insertions(+), 35 deletions(-)
> 
> Acked-by: Trond Myklebust <trond.myklebust@primarydata.com>
> 

Thanks. While spinning this up, I did have a momentary pause to wonder
if -ENOLCK would be a better return value here.

It would make it easier to distinguish this from from "oops, I passed
in bogus arguments". For now, I'll leave it as -EINVAL, but it's
something to consider...

-- 
Jeff Layton <jlayton@primarydata.com>