From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755072AbaIDSec (ORCPT ); Thu, 4 Sep 2014 14:34:32 -0400 Received: from mail-pa0-f51.google.com ([209.85.220.51]:58606 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751620AbaIDSea (ORCPT ); Thu, 4 Sep 2014 14:34:30 -0400 Date: Thu, 4 Sep 2014 11:34:21 -0700 From: Dmitry Torokhov To: Heiko =?iso-8859-1?Q?St=FCbner?= Cc: Chris Zhong , dianders@chromium.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, sameo@linux.intel.com, lee.jones@linaro.org, lgirdwood@gmail.com, a.zummo@towertech.it, mturquette@linaro.org, akpm@linux-foundation.org, broonie@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com, grant.likely@linaro.org, hl@rock-chips.com, huangtao@rock-chips.com, cf@rock-chips.com, zhangqing@rock-chips.com, xxx@rock-chips.com, olof@lixom.net, sonnyrao@chromium.org, javier.martinez@collabora.co.uk, kever.yang@rock-chips.com Subject: Re: [PATCH v9 2/3] clk: RK808: Add clkout driver for RK808 Message-ID: <20140904183421.GE10224@core.coreip.homeip.net> References: <1409793159-2573-1-git-send-email-zyw@rock-chips.com> <1409793159-2573-3-git-send-email-zyw@rock-chips.com> <20140904174024.GD10224@core.coreip.homeip.net> <3708545.id8zLgF0vo@diego> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3708545.id8zLgF0vo@diego> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 04, 2014 at 08:02:56PM +0200, Heiko Stübner wrote: > Am Donnerstag, 4. September 2014, 10:40:24 schrieb Dmitry Torokhov: > > Hi Chris, > > > > On Thu, Sep 04, 2014 at 09:12:38AM +0800, Chris Zhong wrote: > > > + rk808_clkout->clk_data.clks = clk_table; > > > + rk808_clkout->clk_data.clk_num = RK808_NR_OUTPUT; > > > + > > > + return of_clk_add_provider(node, of_clk_src_onecell_get, > > > + &rk808_clkout->clk_data); > > > +} > > > + > > > +static struct platform_driver rk808_clkout_driver = { > > > + .probe = rk808_clkout_probe, > > > + .driver = { > > > + .name = "rk808-clkout", > > > + }, > > > +}; > > > > Shouldn't there also be: > > > > static int rk808_clkout_probe(struct platform_device *pdev) > ^^ remove > > Just to prevent confusion. And you're right there of course. Ah, yes, stupid cut-and-paste... -- Dmitry