From: Mark Brown <broonie@kernel.org>
To: Gyungoh Yoo <gyungoh@gmail.com>
Cc: lgirdwood@gmail.com, grant.likely@linaro.org, robh+dt@kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Gyungoh Yoo <jack.yoo@skyworksinc.com>
Subject: Re: [PATCH v2.2 2/2] dt-bindings: Adding compatible attribute for SKY81452 regulator
Date: Sat, 6 Sep 2014 15:38:28 +0100 [thread overview]
Message-ID: <20140906143828.GJ2601@sirena.org.uk> (raw)
In-Reply-To: <20140905015507.GA2636@jack-ThinkPad-T520>
[-- Attachment #1: Type: text/plain, Size: 843 bytes --]
On Fri, Sep 05, 2014 at 10:55:07AM +0900, Gyungoh Yoo wrote:
> On Mon, Sep 01, 2014 at 11:31:58AM +0100, Mark Brown wrote:
> > Why is this a good idea - can this driver be used for anything other
> > than a sky81452?
> Yes. There is a possibility that this driver will be used by similar
> device with SKY81452.
OK, so tha was slightly the wrong question. What added information is
forcing the user to create a subnode and specify a compatible string
providing? This driver is specifying a block of multiple regulators
with absolute register addresses hard coded into it, there's no real
ability to use the driver in a different configuration here. As soon as
we see the parent device we already know everything there is to know
about the IP block, having a separate compatible string just forces the
user to do more typing for no gain.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-09-06 14:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-08 9:10 [PATCH 2/3] Adding Skyworks SKY81452 regulator driver Gyungoh Yoo
2014-08-13 19:04 ` Mark Brown
2014-09-01 2:40 ` [PATCH v2.2 0/2] regulator: sky81452: Adding compatible attribute in DT document Gyungoh Yoo
2014-09-01 2:40 ` [PATCH v2.2 1/2] regulator: sky81452: Adding compatible attribute in DT Gyungoh Yoo
2014-09-01 2:40 ` [PATCH v2.2 2/2] dt-bindings: Adding compatible attribute for SKY81452 regulator Gyungoh Yoo
2014-09-01 10:31 ` Mark Brown
2014-09-05 1:55 ` Gyungoh Yoo
2014-09-06 14:38 ` Mark Brown [this message]
2014-09-11 5:22 ` Gyungoh Yoo
2014-09-15 22:35 ` Mark Brown
2014-09-19 6:17 ` Gyungoh Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140906143828.GJ2601@sirena.org.uk \
--to=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=gyungoh@gmail.com \
--cc=jack.yoo@skyworksinc.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®