From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753693AbaIHLgI (ORCPT ); Mon, 8 Sep 2014 07:36:08 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:56989 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753163AbaIHLgF (ORCPT ); Mon, 8 Sep 2014 07:36:05 -0400 Date: Mon, 8 Sep 2014 12:35:47 +0100 From: Mark Brown To: Anders Berg Cc: Linus Walleij , "linux-spi@vger.kernel.org" , Alexandre Courbot , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Message-ID: <20140908113547.GJ4015@sirena.org.uk> References: <1409576021-24828-1-git-send-email-anders.berg@avagotech.com> <1409576021-24828-2-git-send-email-anders.berg@avagotech.com> <20140904170630.GL29327@sirena.org.uk> <20140906135308.GC2601@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="mhjHhnbe5PrRcwjY" Content-Disposition: inline In-Reply-To: X-Cookie: See label for sequence. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 1/2] gpio: Add driver for AXM55xx SSP chip selects X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --mhjHhnbe5PrRcwjY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Sep 08, 2014 at 01:02:32PM +0200, Anders Berg wrote: > On Sat, Sep 6, 2014 at 3:53 PM, Mark Brown wrote: > > Would it not be more straightforward to just register it as a platform > > device in this case, or use a separate OF ID in the DT? We appear to > > specify a compatible string when registering AMBA devices even if we are > > capable of identifying using the ID registers. > I'll drop this gpio patch for now and submit a patch on the pl022 > driver instead. I read the arm,primecell binding and learned that > there is a property (arm,primecell-periphid) that can be used to > override the HW PrimeCell ID. Seems like something to use here, right? Possibly, though if there's no hardware ID to override to that might not be the best option. You could always define a property that's specific to the pl022 driver flagging that it's got these extra chip selects though. --mhjHhnbe5PrRcwjY Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJUDZSTAAoJECTWi3JdVIfQ/AsH/iHCP5Aalikko8/T0dqeY94z fNwr+78Oo/IlKhNOnt9/gySYurhzeVi04FMpGQ4eoVmbaC+K5yAwBw+aBbOyC7HF pYqvO7uVR9pMab685pJTpiIsN0l7u8Kgkubc9Q+4oc8P/zYtWI83ou7ZsdN+oeM9 kk5myErUMVKCuDCSuJikhtmQjIEPZa6aSFnsWnGGnU8xB0PEGeRx/v2uLv/d0WcL yFe4Mvwvyl2sAgpn2YiI+5xlPMW9J99hVte0WM99j1W5nt3nnl6uF/vX+UYt8Lp0 wphT5YptZ/vJYwMz+pNTX6cLjbv/zwGLxHTnC2OUPIdjVegwRQJiiGKRuPg5bcw= =Nc6W -----END PGP SIGNATURE----- --mhjHhnbe5PrRcwjY--