From: Greg KH <gregkh@linuxfoundation.org>
To: Spencer Baugh <sbaugh@andrew.cmu.edu>
Cc: Oleg Drokin <oleg.drokin@intel.com>,
Niu Yawei <yawei.niu@intel.com>,
Masanari Iida <standby24x7@gmail.com>,
Hongchao Zhang <hongchao.zhang@intel.com>,
"open list:STAGING SUBSYSTEM" <devel@driverdev.osuosl.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] staging: lustre: fix function definition style
Date: Mon, 8 Sep 2014 12:40:03 -0700 [thread overview]
Message-ID: <20140908194003.GA13205@kroah.com> (raw)
In-Reply-To: <1410025111-31422-1-git-send-email-sbaugh@andrew.cmu.edu>
On Sat, Sep 06, 2014 at 01:38:27PM -0400, Spencer Baugh wrote:
> Fix errors reported by checkpatch of this kind:
> ERROR: open brace '{' following function declarations go on the next line
>
> Signed-off-by: Spencer Baugh <sbaugh@andrew.cmu.edu>
> ---
> drivers/staging/lustre/lustre/include/lustre_import.h | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/lustre/lustre/include/lustre_import.h b/drivers/staging/lustre/lustre/include/lustre_import.h
> index 8304a55..feb4291 100644
> --- a/drivers/staging/lustre/lustre/include/lustre_import.h
> +++ b/drivers/staging/lustre/lustre/include/lustre_import.h
> @@ -346,21 +346,24 @@ static inline unsigned int at_timeout2est(unsigned int val)
> return (max((val << 2) / 5, 5U) - 4);
> }
>
> -static inline void at_reset(struct adaptive_timeout *at, int val) {
> +static inline void at_reset(struct adaptive_timeout *at, int val)
You are adding whitespace errors with this patch, I can't take this
series because of this :(
Please always run your patches through scripts/checkpatch.pl to ensure
you aren't adding new problems.
Can you fix this series of patches up and resend?
thanks,
greg k-h
prev parent reply other threads:[~2014-09-08 19:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-06 17:38 Spencer Baugh
2014-09-06 17:38 ` [PATCH 2/3] staging: lustre: fix pointer whitespace style Spencer Baugh
2014-09-06 18:19 ` Joe Perches
2014-09-08 10:32 ` Dan Carpenter
2014-09-08 11:37 ` Joe Perches
2014-09-06 17:38 ` [PATCH 3/3] staging: lustre: remove trailing whitespace Spencer Baugh
2014-09-08 19:40 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140908194003.GA13205@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=hongchao.zhang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg.drokin@intel.com \
--cc=sbaugh@andrew.cmu.edu \
--cc=standby24x7@gmail.com \
--cc=yawei.niu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome