mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Hugues <morisset.hugues@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] staging: lustre: fix coding style issues
Date: Mon, 8 Sep 2014 15:13:53 -0700	[thread overview]
Message-ID: <20140908221353.GA21671@kroah.com> (raw)
In-Reply-To: <540E27FB.2070206@gmail.com>

On Tue, Sep 09, 2014 at 12:04:43AM +0200, Hugues wrote:
> Fix coding style issues:
> * limit the length of changed lines to 80 columns.

Why isn't this in the body of the changelog?

> >From a244d32aa34d0b13ac40dd014b88d0ff5ed10817 Mon Sep 17 00:00:00 2001
> From: Hugues Morisset <morisset.hugues@gmail.com>
> Date: Mon, 8 Sep 2014 21:23:28 +0200
> Subject: [PATCH 1/4] staging: lustre: fix coding style issues
> 
> Signed-off-by: Hugues Morisset <morisset.hugues@gmail.com>
> ---
>  drivers/staging/lustre/lustre/include/obd.h | 46 ++++++++++++++++-------------
>  1 file changed, 25 insertions(+), 21 deletions(-)

I can't take patches in attachments, please put them in-line and use git
send-email to send them properly.

Please fix up and resend this whole series.

thanks,

greg k-h

  parent reply	other threads:[~2014-09-08 22:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-08 22:04 Hugues
2014-09-08 22:06 ` [PATCH 2/4] " Hugues
2014-09-08 22:07   ` [PATCH 3/4] " Hugues
2014-09-08 22:09     ` Hugues
2014-09-08 22:12     ` [PATCH 4/4] staging: lustre: Fix potential buffer underflow Hugues
2014-09-08 22:38       ` Dan Carpenter
2014-09-08 23:31         ` Drokin, Oleg
2014-09-08 22:13 ` Greg KH [this message]
2014-09-08 22:21 ` [PATCH 1/4] staging: lustre: fix coding style issues Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140908221353.GA21671@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=morisset.hugues@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome