From: Felipe Balbi <balbi@ti.com>
To: Robert Baldyga <r.baldyga@samsung.com>
Cc: <balbi@ti.com>, <gregkh@linuxfoundation.org>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v8 1/3] usb: gadget: f_fs: fix the redundant ep files problem
Date: Tue, 9 Sep 2014 10:04:26 -0500 [thread overview]
Message-ID: <20140909150425.GK6151@saruman.home> (raw)
In-Reply-To: <1410243797-9719-2-git-send-email-r.baldyga@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 1462 bytes --]
On Tue, Sep 09, 2014 at 08:23:15AM +0200, Robert Baldyga wrote:
> Up to now, when endpoint addresses in descriptors were non-consecutive,
> there were created redundant files, which could cause problems in kernel,
> when user tried to read/write to them. It was result of fact that maximum
> endpoint address was taken as total number of endpoints in funciton.
>
> This patch adds endpoint descriptors counting and storing their addresses
> in eps_addrmap to verify their cohesion in each speed.
>
> Endpoint address map would be also useful for further features, just like
> vitual endpoint address mapping.
>
> Signed-off-by: Robert Baldyga <r.baldyga@samsung.com>
> Acked-by: Michal Nazarewicz <mina86@mina86.com>
This is a fix, which sits in my 'fixes' branch. You can't include it
here. This series should be rebased on top of my 'next' but it should
not include any fixes, only new code.
This is why we generally ask people to split the series up into fixes
and new code and not make them depend on each other. You need to
remember that, rather frequently, my 'next' branch is based off of -rc1.
I only merge an -rc back into my 'next' when the conflicts start to
become non-trivial because of all the dependencies people add :-)
I'll see if I can fix this up myself, but if I can't, then we either
postpone this series to v3.19 or you get it done properly and without
any cross-dependencies :-)
cheers
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-09-09 15:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 6:23 [PATCH v8 0/3] usb: gadget: f_fs: userspace API fixes and improvements Robert Baldyga
2014-09-09 6:23 ` [PATCH v8 1/3] usb: gadget: f_fs: fix the redundant ep files problem Robert Baldyga
2014-09-09 15:04 ` Felipe Balbi [this message]
2014-09-09 15:09 ` Felipe Balbi
2014-09-09 6:23 ` [PATCH v8 2/3] usb: gadget: f_fs: add ioctl returning ep descriptor Robert Baldyga
2014-09-09 6:23 ` [PATCH v8 3/3] usb: gadget: f_fs: virtual endpoint address mapping Robert Baldyga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140909150425.GK6151@saruman.home \
--to=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=r.baldyga@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome