From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757332AbaIIQnW (ORCPT ); Tue, 9 Sep 2014 12:43:22 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:56279 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757094AbaIIQnV (ORCPT ); Tue, 9 Sep 2014 12:43:21 -0400 Date: Wed, 10 Sep 2014 01:43:16 +0900 From: Tejun Heo To: Alan Stern Cc: James Bottomley , Shirish Pargaonkar , Jens Axboe , SCSI development list , Kernel development list Subject: Re: [PATCH] Block: fix unbalanced bypass-disable in blk_register_queue Message-ID: <20140909164316.GA11748@mtj.dyndns.org> References: <20140909151726.GA8890@mtj.dyndns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 09, 2014 at 11:50:58AM -0400, Alan Stern wrote: > When a queue is registered, the block layer turns off the bypass > setting (because bypass is enabled when the queue is created). This > doesn't work well for queues that are unregistered and then registered > again; we get a WARNING because of the unbalanced calls to > blk_queue_bypass_end(). > > This patch fixes the problem by making blk_register_queue() call > blk_queue_bypass_end() only the first time the queue is registered. > > Signed-off-by: Alan Stern > CC: Tejun Heo > CC: James Bottomley > CC: Jens Axboe Acked-by: Tejun Heo Thanks. -- tejun