From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752141AbaIISif (ORCPT ); Tue, 9 Sep 2014 14:38:35 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:42312 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751177AbaIISie (ORCPT ); Tue, 9 Sep 2014 14:38:34 -0400 Date: Tue, 9 Sep 2014 11:38:32 -0700 From: Christoph Hellwig To: Ming Lei Cc: Jens Axboe , linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Christoph Hellwig Subject: Re: [PATCH 4/8] block: avoid to use q->flush_rq directly Message-ID: <20140909183832.GD16750@infradead.org> References: <1410267949-21904-1-git-send-email-ming.lei@canonical.com> <1410267949-21904-5-git-send-email-ming.lei@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1410267949-21904-5-git-send-email-ming.lei@canonical.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 09, 2014 at 09:05:45PM +0800, Ming Lei wrote: > This patch trys to use local variable to access flush request, > so that we can convert to per-queue flush machinery a bit easier. > > Signed-off-by: Ming Lei Looks good, Reviewed-by: Christoph Hellwig