From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752039AbaIJHXs (ORCPT ); Wed, 10 Sep 2014 03:23:48 -0400 Received: from mail.kernel.org ([198.145.19.201]:45531 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750988AbaIJHXq (ORCPT ); Wed, 10 Sep 2014 03:23:46 -0400 Date: Wed, 10 Sep 2014 00:23:44 -0700 From: Jaegeuk Kim To: Chao Yu Cc: "'Tommi Rantala'" , "'Dave Jones'" , trinity@vger.kernel.org, "'LKML'" , linux-f2fs-devel@lists.sourceforge.net Subject: Re: [f2fs-dev] f2fs get_dnode_of_data oops Message-ID: <20140910072344.GB9242@jaegeuk-mac02.mot-mobility.com> References: <20140908042056.GA13863@jaegeuk-mac02.hsd1.ca.comcast.net> <20140909044157.GA24581@jaegeuk-mac02.hsd1.ca.comcast.net> <003301cfcc05$95bfc6f0$c13f54d0$@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <003301cfcc05$95bfc6f0$c13f54d0$@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 09, 2014 at 04:10:00PM +0800, Chao Yu wrote: > Hi Jaegeuk, > > Looks good to me! > > One nitpick, how about judging this condition before we lock ->i_mutex to > avoid unneeded lock contention and invoking of i_size_read()? Agreed. >>From 0b4c5afde9b57c08b55d26725d228d5314cfc57a Mon Sep 17 00:00:00 2001 From: Jaegeuk Kim Date: Mon, 8 Sep 2014 10:59:43 -0700 Subject: [PATCH] f2fs: fix negative value for lseek offset If application throws negative value of lseek with SEEK_DATA|SEEK_HOLE, previous f2fs went into BUG_ON in get_dnode_of_data, which was reported by Tommi Rantala. He could make a simple code to detect this having: lseek(fd, -17595150933902LL, SEEK_DATA); This patch should resolve that bug. Reported-by: Tommi Rentala [Jaegeuk Kim: relocate the condition as suggested by Chao] Signed-off-by: Jaegeuk Kim --- fs/f2fs/file.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index 9f0ea3d..5cde363 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -353,6 +353,8 @@ static loff_t f2fs_llseek(struct file *file, loff_t offset, int whence) maxbytes, i_size_read(inode)); case SEEK_DATA: case SEEK_HOLE: + if (offset < 0) + return -ENXIO; return f2fs_seek_block(file, offset, whence); } -- 1.8.5.2 (Apple Git-48)