From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752851AbaIJSHw (ORCPT ); Wed, 10 Sep 2014 14:07:52 -0400 Received: from mail-pa0-f53.google.com ([209.85.220.53]:35351 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751727AbaIJSHt (ORCPT ); Wed, 10 Sep 2014 14:07:49 -0400 Date: Wed, 10 Sep 2014 11:07:45 -0700 From: Dmitry Torokhov To: Stephen Warren Cc: nick.dyer@itdev.co.uk, Yufeng Shen , Daniel Kurtz , Henrik Rydberg , Joonyoung Shim , Alan Bowens , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Meerwald , Benson Leung , Olof Johansson , Sekhar Nori Subject: Re: [PATCH 2/2 v2] Input: atmel_mxt_ts - fix double free of input device Message-ID: <20140910180745.GA38736@core.coreip.homeip.net> References: <541060D8.9020707@itdev.co.uk> <1410359581-16284-1-git-send-email-nick.dyer@itdev.co.uk> <54108A30.80003@wwwdotorg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54108A30.80003@wwwdotorg.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 10, 2014 at 11:28:16AM -0600, Stephen Warren wrote: > On 09/10/2014 08:33 AM, nick.dyer@itdev.co.uk wrote: > >From: Stephen Warren > > > >[reworked after comments by Dmitry Torokhov. Move free of input device into > >separate function. Only call in paths that require it.] > >Signed-off-by: Nick Dyer > > I re-tested this, and see no issues after inserting/removing the > module a few times. Applied, thank you. -- Dmitry