From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754092AbaIKKHG (ORCPT ); Thu, 11 Sep 2014 06:07:06 -0400 Received: from top.free-electrons.com ([176.31.233.9]:44193 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753153AbaIKKHE (ORCPT ); Thu, 11 Sep 2014 06:07:04 -0400 Date: Thu, 11 Sep 2014 12:06:59 +0200 From: Boris BREZILLON To: Johan Hovold Cc: Nicolas Ferre , Jean-Christophe Plagniol-Villard , Alexandre Belloni , Andrew Victor , Alessandro Zummo , rtc-linux@googlegroups.com, Johan Hovold , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Douglas Gilbert Subject: Re: [PATCH v3 0/8] rtc: at91sam9: add DT support Message-ID: <20140911120659.14daa624@bbrezillon> In-Reply-To: <20140911093942.GA12295@localhost> References: <1410425767-17874-1-git-send-email-boris.brezillon@free-electrons.com> <20140911093942.GA12295@localhost> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 11 Sep 2014 11:39:42 +0200 Johan Hovold wrote: > On Thu, Sep 11, 2014 at 10:55:59AM +0200, Boris BREZILLON wrote: > > > Johan, let me know if this version addresses part of your concerns. > > Looks good to me. I just have a few minor comments on two of the patches. > > > I'm open to any suggestion/rework to address other previously discussed > > issues, as long as it does not end up in a dead-end (like the discussion > > you had last year): > > - the fact that the RTT block could be used for something that is not > > an RTC > > - the fact that referencing the GPBR node and defining a GPBR register > > number to store RTC time info could be considered as an HW config and > > not an HW description and thus should not be described in the DT > > No doubt. Okay then. Any suggestion to do otherwise ? Alexandre suggested to pass the GPBR register number through a module parameter, and retrieve the GPBR syscon by searching for a gpbr node (or atmel,at91sam9260-gpbr compatible node) in the device tree. I'm not a big fan of this solution, as it implies passing driver specific config to the global cmdline (and we'll have to handle the 9263 case where 2 RTT blocks are availables). Best Regards, Boris -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com