From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753553AbaIKWFQ (ORCPT ); Thu, 11 Sep 2014 18:05:16 -0400 Received: from top.free-electrons.com ([176.31.233.9]:50668 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752186AbaIKWFN (ORCPT ); Thu, 11 Sep 2014 18:05:13 -0400 Date: Fri, 12 Sep 2014 00:05:00 +0200 From: Thomas Petazzoni To: Boris BREZILLON Cc: Ezequiel Garcia , Nicolas Ferre , linux-kernel@vger.kernel.org, Alexandre Belloni , linux-mtd@lists.infradead.org, Brian Norris , David Woodhouse , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] mtd: nand: atmel_nand: retrieve NFC clock Message-ID: <20140912000500.5a1d5f75@free-electrons.com> In-Reply-To: <20140911173854.73b201e7@bbrezillon> References: <1410446617-29572-1-git-send-email-alexandre.belloni@free-electrons.com> <20140911152029.GA16666@arch> <20140911173854.73b201e7@bbrezillon> Organization: Free Electrons X-Mailer: Claws Mail 3.10.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dear Boris BREZILLON, On Thu, 11 Sep 2014 17:38:54 +0200, Boris BREZILLON wrote: > > Anyway, with or without the docs I think this patch breaks DT backward > > compatibility. > > > > Or am I missing something? > > Indeed, this block of code should be placed at the end of the probe > function. I'll fix that. > > Note that if the clk is missing it just print a warning message and > return 0, so after moving the code, it should not break DT backward > compat ;-). You may want to use: dev_warn(FW_WARN "NFC clock missing, update your Device Tree\n"); Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com