From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752993AbaILWFk (ORCPT ); Fri, 12 Sep 2014 18:05:40 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:56429 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752879AbaILWFj (ORCPT ); Fri, 12 Sep 2014 18:05:39 -0400 Date: Fri, 12 Sep 2014 15:05:37 -0700 From: Andrew Morton To: Javier Martinez Canillas Cc: Alessandro Zummo , Doug Anderson , Olof Johansson , Krzysztof Kozlowski , rtc-linux@googlegroups.com, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND v9 1/5] rtc: max77686: Allow the max77686 rtc to wakeup the system Message-Id: <20140912150537.56419981804c68f9108a22b6@linux-foundation.org> In-Reply-To: <1410509864-10019-2-git-send-email-javier.martinez@collabora.co.uk> References: <1410509864-10019-1-git-send-email-javier.martinez@collabora.co.uk> <1410509864-10019-2-git-send-email-javier.martinez@collabora.co.uk> X-Mailer: Sylpheed 3.2.0beta5 (GTK+ 2.24.10; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 12 Sep 2014 10:17:39 +0200 Javier Martinez Canillas wrote: > From: Doug Anderson > > The max77686 includes an RTC that keeps power during suspend. It's > convenient to be able to use it as a wakeup source. > > NOTE: due to wakeup ordering problems this patch alone doesn't work so > well on exynos5250-snow. You also need something that brings the i2c > bus up before the max77686 wakeup runs. I removed this paragraph. > Signed-off-by: Doug Anderson > Reviewed-by: Javier Martinez Canillas And I rewrote this to Signed-off-by:, as you were on the patch delivery path. Documentation/SubmittingPatches section 12 has the gory details.