From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: xypron.glpk@gmx.de, david.daney@cavium.com, luka@openwrt.org,
willemb@google.com, rmk+kernel@arm.linux.org.uk,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] netdev: octeon_mgmt: ISO C90 forbids mixed declarations and code
Date: Sat, 13 Sep 2014 16:03:02 -0400 (EDT) [thread overview]
Message-ID: <20140913.160302.698126980021738731.davem@davemloft.net> (raw)
In-Reply-To: <1410635472.917.1.camel@joe-AO725>
From: Joe Perches <joe@perches.com>
Date: Sat, 13 Sep 2014 12:11:12 -0700
> On Sat, 2014-09-13 at 21:05 +0200, Heinrich Schuchardt wrote:
>> Compiling with OCTEON_MGMT_ETHERNET gives a warning
>> drivers/net/ethernet/octeon/octeon_mgmt.c:295:4:
>> warning: ISO C90 forbids mixed declarations and code
>> [-Wdeclaration-after-statement]
>
> Maybe better to move the memset after the declaration.
Totally agree, keep the variable in the innermost scope
in which it is used.
prev parent reply other threads:[~2014-09-13 20:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-13 19:05 Heinrich Schuchardt
2014-09-13 19:11 ` Joe Perches
2014-09-13 20:03 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140913.160302.698126980021738731.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=david.daney@cavium.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luka@openwrt.org \
--cc=netdev@vger.kernel.org \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=willemb@google.com \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®