From: Andrew Lunn <andrew@lunn.ch>
To: Joe Perches <joe@perches.com>
Cc: linux-arm-kernel@lists.infradead.org,
Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Russell King <linux@arm.linux.org.uk>,
Alexander Clouter <alex@digriz.org.uk>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/8] arm: mach-orion5x: Convert pr_warning to pr_warn
Date: Sat, 13 Sep 2014 21:16:12 +0200 [thread overview]
Message-ID: <20140913191612.GB24502@lunn.ch> (raw)
In-Reply-To: <b438c7c54306f095a150e50df41fbba4d515c2f8.1410632835.git.joe@perches.com>
On Sat, Sep 13, 2014 at 11:31:17AM -0700, Joe Perches wrote:
> Use the more common pr_warn.
>
> Other miscellanea:
>
> o Realign arguments
>
> Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: Andrew Lunn <andrew@lunn.ch>
Andrew
> ---
> arch/arm/mach-orion5x/dns323-setup.c | 8 ++++----
> arch/arm/mach-orion5x/terastation_pro2-setup.c | 2 +-
> arch/arm/mach-orion5x/ts209-setup.c | 2 +-
> arch/arm/mach-orion5x/ts409-setup.c | 2 +-
> arch/arm/mach-orion5x/ts78xx-setup.c | 4 ++--
> 5 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/arch/arm/mach-orion5x/dns323-setup.c b/arch/arm/mach-orion5x/dns323-setup.c
> index 56edeab..09d2a26 100644
> --- a/arch/arm/mach-orion5x/dns323-setup.c
> +++ b/arch/arm/mach-orion5x/dns323-setup.c
> @@ -550,7 +550,7 @@ static int __init dns323_identify_rev(void)
> break;
> }
> if (i >= 1000) {
> - pr_warning("DNS-323: Timeout accessing PHY, assuming rev B1\n");
> + pr_warn("DNS-323: Timeout accessing PHY, assuming rev B1\n");
> return DNS323_REV_B1;
> }
> writel((3 << 21) /* phy ID reg */ |
> @@ -562,7 +562,7 @@ static int __init dns323_identify_rev(void)
> break;
> }
> if (i >= 1000) {
> - pr_warning("DNS-323: Timeout reading PHY, assuming rev B1\n");
> + pr_warn("DNS-323: Timeout reading PHY, assuming rev B1\n");
> return DNS323_REV_B1;
> }
> pr_debug("DNS-323: Ethernet PHY ID 0x%x\n", reg & 0xffff);
> @@ -577,8 +577,8 @@ static int __init dns323_identify_rev(void)
> case 0x0e10: /* MV88E1118 */
> return DNS323_REV_C1;
> default:
> - pr_warning("DNS-323: Unknown PHY ID 0x%04x, assuming rev B1\n",
> - reg & 0xffff);
> + pr_warn("DNS-323: Unknown PHY ID 0x%04x, assuming rev B1\n",
> + reg & 0xffff);
> }
> return DNS323_REV_B1;
> }
> diff --git a/arch/arm/mach-orion5x/terastation_pro2-setup.c b/arch/arm/mach-orion5x/terastation_pro2-setup.c
> index 6208d12..1208674 100644
> --- a/arch/arm/mach-orion5x/terastation_pro2-setup.c
> +++ b/arch/arm/mach-orion5x/terastation_pro2-setup.c
> @@ -349,7 +349,7 @@ static void __init tsp2_init(void)
> gpio_free(TSP2_RTC_GPIO);
> }
> if (tsp2_i2c_rtc.irq == 0)
> - pr_warning("tsp2_init: failed to get RTC IRQ\n");
> + pr_warn("tsp2_init: failed to get RTC IRQ\n");
> i2c_register_board_info(0, &tsp2_i2c_rtc, 1);
>
> /* register Terastation Pro II specific power-off method */
> diff --git a/arch/arm/mach-orion5x/ts209-setup.c b/arch/arm/mach-orion5x/ts209-setup.c
> index 9136797..c725b7c 100644
> --- a/arch/arm/mach-orion5x/ts209-setup.c
> +++ b/arch/arm/mach-orion5x/ts209-setup.c
> @@ -314,7 +314,7 @@ static void __init qnap_ts209_init(void)
> gpio_free(TS209_RTC_GPIO);
> }
> if (qnap_ts209_i2c_rtc.irq == 0)
> - pr_warning("qnap_ts209_init: failed to get RTC IRQ\n");
> + pr_warn("qnap_ts209_init: failed to get RTC IRQ\n");
> i2c_register_board_info(0, &qnap_ts209_i2c_rtc, 1);
>
> /* register tsx09 specific power-off method */
> diff --git a/arch/arm/mach-orion5x/ts409-setup.c b/arch/arm/mach-orion5x/ts409-setup.c
> index 5c079d31..cf2ab53 100644
> --- a/arch/arm/mach-orion5x/ts409-setup.c
> +++ b/arch/arm/mach-orion5x/ts409-setup.c
> @@ -302,7 +302,7 @@ static void __init qnap_ts409_init(void)
> gpio_free(TS409_RTC_GPIO);
> }
> if (qnap_ts409_i2c_rtc.irq == 0)
> - pr_warning("qnap_ts409_init: failed to get RTC IRQ\n");
> + pr_warn("qnap_ts409_init: failed to get RTC IRQ\n");
> i2c_register_board_info(0, &qnap_ts409_i2c_rtc, 1);
> platform_device_register(&ts409_leds);
>
> diff --git a/arch/arm/mach-orion5x/ts78xx-setup.c b/arch/arm/mach-orion5x/ts78xx-setup.c
> index db16dae..1b704d3 100644
> --- a/arch/arm/mach-orion5x/ts78xx-setup.c
> +++ b/arch/arm/mach-orion5x/ts78xx-setup.c
> @@ -403,8 +403,8 @@ static void ts78xx_fpga_supports(void)
> /* enable devices if magic matches */
> switch ((ts78xx_fpga.id >> 8) & 0xffffff) {
> case TS7800_FPGA_MAGIC:
> - pr_warning("unrecognised FPGA revision 0x%.2x\n",
> - ts78xx_fpga.id & 0xff);
> + pr_warn("unrecognised FPGA revision 0x%.2x\n",
> + ts78xx_fpga.id & 0xff);
> ts78xx_fpga.supports.ts_rtc.present = 1;
> ts78xx_fpga.supports.ts_nand.present = 1;
> ts78xx_fpga.supports.ts_rng.present = 1;
> --
> 1.8.1.2.459.gbcd45b4.dirty
>
next prev parent reply other threads:[~2014-09-13 19:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-13 18:31 [PATCH 0/8] arm: " Joe Perches
2014-09-13 18:31 ` [PATCH 1/8] " Joe Perches
2014-09-15 15:56 ` Will Deacon
2014-09-15 16:02 ` Joe Perches
2014-09-16 16:07 ` Russell King - ARM Linux
2014-09-16 16:18 ` Joe Perches
2014-09-16 19:24 ` Uwe Kleine-König
2014-09-16 19:57 ` Russell King - ARM Linux
2014-09-16 20:08 ` Joe Perches
2014-09-13 18:31 ` [PATCH 2/8] arm: mach-davinci: " Joe Perches
2014-09-13 18:31 ` [PATCH 3/8] arm: mach-ep93xx: " Joe Perches
2014-09-13 18:31 ` [PATCH 4/8] arm: mach-imx: " Joe Perches
2014-09-16 1:51 ` Shawn Guo
2014-09-13 18:31 ` [PATCH 5/8] arm: mach-omap2: " Joe Perches
2014-09-18 16:54 ` Tony Lindgren
2014-09-13 18:31 ` [PATCH 6/8] arm: mach-orion5x: " Joe Perches
2014-09-13 19:16 ` Andrew Lunn [this message]
2014-09-13 21:51 ` Jason Cooper
2014-09-13 18:31 ` [PATCH 7/8] arm: mach-pxa: " Joe Perches
2014-09-21 17:02 ` Robert Jarzmik
2014-09-13 18:31 ` [PATCH 8/8] arm: mach-u300: " Joe Perches
2014-09-23 15:10 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140913191612.GB24502@lunn.ch \
--to=andrew@lunn.ch \
--cc=alex@digriz.org.uk \
--cc=jason@lakedaemon.net \
--cc=joe@perches.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®