mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: kan.liang@intel.com
Cc: acme@kernel.org, linux-kernel@vger.kernel.org, ak@linux.intel.com
Subject: Re: [PATCH V6 0/3] perf tools: pmu event new style format fix
Date: Sun, 14 Sep 2014 15:23:22 +0200	[thread overview]
Message-ID: <20140914132322.GB1731@krava.redhat.com> (raw)
In-Reply-To: <1410462539-5468-1-git-send-email-kan.liang@intel.com>

On Thu, Sep 11, 2014 at 03:08:56PM -0400, kan.liang@intel.com wrote:
> From: Kan Liang <kan.liang@intel.com>
> 
> There are two types of pmu event stytle formats, "pmu_event_name"
> or "cpu/pmu_event_name/". However, there is a bug on supporting these
> two formats, especially when they mixed with other perf events.
> The patch set intends to fix this issue.
> 
> The patch set has been tested on my haswell.
> Here is the test script I used for this issue.
> (Note: please make sure that your test system supports TSX and
> L1-dcache-loads events. Otherwise, you may want to change the events 
> to other pmu events.)

any chance changing this script to work for everyone?
and make it part of theautomated tests suite?

also how about something like in the attached change

jirka


---
diff --git a/tools/perf/tests/parse-events.c b/tools/perf/tests/parse-events.c
index 5941927a4b7f..2b7c48474761 100644
--- a/tools/perf/tests/parse-events.c
+++ b/tools/perf/tests/parse-events.c
@@ -1554,6 +1554,15 @@ static int test_pmu_events(void)
 		e.check = test__checkevent_pmu_events;
 
 		ret = test_event(&e);
+		if (ret)
+			break;
+
+		snprintf(name, MAX_NAME, "event=%s", ent->d_name);
+
+		e.name  = name;
+		e.check = test__checkevent_pmu_events;
+
+		ret = test_event(&e);
 #undef MAX_NAME
 	}

  parent reply	other threads:[~2014-09-14 13:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-11 19:08 kan.liang
2014-09-11 19:08 ` [PATCH V6 1/3] Revert "perf tools: Default to cpu// for events v5" kan.liang
2014-09-11 19:08 ` [PATCH V6 2/3] perf tools: parse the pmu event prefix and surfix kan.liang
2014-09-14 13:23   ` Jiri Olsa
2014-10-02 17:33     ` Liang, Kan
2014-10-03  8:23       ` Jiri Olsa
2014-09-11 19:08 ` [PATCH V6 3/3] perf tools: Add support to new style format of kernel PMU event kan.liang
2014-09-14 13:23 ` Jiri Olsa [this message]
2014-10-02 17:33   ` [PATCH V6 0/3] perf tools: pmu event new style format fix Liang, Kan
2014-10-03  8:24     ` Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140914132322.GB1731@krava.redhat.com \
    --to=jolsa@redhat.com \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=kan.liang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®