From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754133AbaIORru (ORCPT ); Mon, 15 Sep 2014 13:47:50 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:36134 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750956AbaIORrt (ORCPT ); Mon, 15 Sep 2014 13:47:49 -0400 Date: Mon, 15 Sep 2014 10:47:47 -0700 From: Darren Hart To: Azael Avalos Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 4/5] toshiba_acpi: Support new keyboard backlight type Message-ID: <20140915174747.GB59389@vmdeb7> References: <1410569437-3066-1-git-send-email-coproscefalo@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1410569437-3066-1-git-send-email-coproscefalo@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 12, 2014 at 06:50:36PM -0600, Azael Avalos wrote: > Newer Toshiba models now come with a new (and different) keyboard > backlight implementation with three modes of operation: TIMER, > ON and OFF, and the LED is now controlled internally by the firmware. > > This patch adds support for that type of backlight, changing the > existing code to accomodate the new implementation. > > The timeout value range is now 1-60 seconds, and the accepted > modes are now: 1 (FN-Z), 2 (AUTO or TIMER), 8 (ON) and 10 (OFF), > this adds two new entries kbd_type and available_kbd_modes, > the first shows the keyboard type and the latter shows the > supported modes depending on the keyboard type. > > Signed-off-by: Azael Avalos > --- > Changes since v3: > Fixed typos on patch description > Dropped changes to toshiba_kbd_bl_mode_show and simply added the new mode mask > drivers/platform/x86/toshiba_acpi.c | 188 ++++++++++++++++++++++++++++++------ > 1 file changed, 156 insertions(+), 32 deletions(-) Queued, thanks Azael. -- Darren Hart Intel Open Source Technology Center