From: David Miller <davem@davemloft.net>
To: hock.leong.kweh@intel.com
Cc: peppe.cavallaro@st.com, rayagond@vayavyalabs.com,
vbridgers2013@gmail.com, srinivas.kandagatla@st.com,
wens@csie.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, boon.leong.ong@intel.com
Subject: Re: [PATCH v2 3/4] net: stmmac: add support for Intel Quark X1000
Date: Wed, 17 Sep 2014 00:55:32 -0400 (EDT) [thread overview]
Message-ID: <20140917.005532.2054822778882237895.davem@davemloft.net> (raw)
In-Reply-To: <F54AEECA5E2B9541821D670476DAE19C2B7E9DCA@PGSMSX102.gar.corp.intel.com>
From: "Kweh, Hock Leong" <hock.leong.kweh@intel.com>
Date: Wed, 17 Sep 2014 02:41:39 +0000
> Thanks for the pointer. I did a quickly checking on the class number to see if
> I could use it for differentiation the ports number. Whereas I found them
> both have the same class number as well. Below shows the "lspci" dump to
> all the PCI devices on Quark X1000 Galileo board (Ethernet controllers are
> 00:14.6 and 00:14.7). Very unfortunately we are unlikely to use the class
> number as well as pci_device_id for the differentiation.
...
> 00:14.6 "Class 0200" "8086" "0937" "8086" "0937"
> 00:14.7 "Class 0200" "8086" "0937" "8086" "0937"
Are you kidding me? It's a perfect way to identify this device, it
properly uses PCI_CLASS_NETWORK_ETHERNET (0x0200) in both cases and
this will not match any other function on this PCI device at all.
Please do as I suggested and use the PCI class for the differentiation
and matching during probing.
next prev parent reply other threads:[~2014-09-17 4:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-11 8:38 [PATCH v2 0/4] net: stmmac: Enable Intel Quark SoC X1000 Ethernet support Kweh Hock Leong
2014-09-11 8:38 ` [PATCH v2 1/4] net: stmmac: enhance to support multiple device instances Kweh Hock Leong
2014-09-11 8:38 ` [PATCH v2 2/4] net: stmmac: better code manageability with platform data struct Kweh Hock Leong
2014-09-11 8:38 ` [PATCH v2 3/4] net: stmmac: add support for Intel Quark X1000 Kweh Hock Leong
2014-09-12 22:14 ` David Miller
2014-09-15 12:42 ` Kweh, Hock Leong
2014-09-16 19:00 ` David Miller
2014-09-17 2:41 ` Kweh, Hock Leong
2014-09-17 4:55 ` David Miller [this message]
2014-09-17 9:11 ` Kweh, Hock Leong
2014-09-17 15:57 ` David Miller
2014-09-11 8:38 ` [PATCH v2 4/4] net: stmmac: add MSI " Kweh Hock Leong
2014-10-01 11:06 [PATCH v2 3/4] net: stmmac: add " Kweh, Hock Leong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140917.005532.2054822778882237895.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=boon.leong.ong@intel.com \
--cc=hock.leong.kweh@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=rayagond@vayavyalabs.com \
--cc=srinivas.kandagatla@st.com \
--cc=vbridgers2013@gmail.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®