mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kevin Easton <kevin@guarana.org>
To: Richard Larocque <rlarocque@google.com>
Cc: mingo@redhat.com, tglx@linutronix.de, hpa@zytor.com,
	luto@amacapital.net, filbranden@google.com, md@google.com,
	gthelen@google.com, x86@kernel.org, linux-api@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/vdso: Add prctl to set per-process VDSO load
Date: Wed, 17 Sep 2014 21:36:46 +1000	[thread overview]
Message-ID: <20140917113646.GA14001@chicago.guarana.org> (raw)
In-Reply-To: <1410912351-31273-1-git-send-email-rlarocque@google.com>

On Tue, Sep 16, 2014 at 05:05:51PM -0700, Richard Larocque wrote:
> +	case PR_SET_VDSO:
> +		if (arg2 == PR_VDSO_ENABLE)
> +			me->signal->disable_vdso = 0;
> +		else if (arg2 == PR_VDSO_DISABLE)
> +			me->signal->disable_vdso = 1;
> +		else
> +			return -EINVAL;
> +		break;
> +	case PR_GET_VDSO:
> +		if (!me->signal->disable_vdso)
> +			error = put_user(PR_VDSO_ENABLE, (int __user *)arg2);
> +		else
> +			error = put_user(PR_VDSO_DISABLE, (int __user *)arg2);
> +		break;

Perhaps both of those should do

if (arg3 || arg4 || arg5)
	return -EINVAL;

    - Kevin

      parent reply	other threads:[~2014-09-17 10:36 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-17  0:05 Richard Larocque
2014-09-17  0:13 ` Andi Kleen
2014-09-17  0:21   ` Richard Larocque
2014-09-17  0:27 ` Andy Lutomirski
2014-09-17  1:18   ` Richard Larocque
2014-09-17  5:00     ` Andy Lutomirski
2014-09-17  5:34       ` Andy Lutomirski
2014-09-17  6:21       ` Filipe Brandenburger
2014-09-17  8:46         ` H. Peter Anvin
2014-09-17 13:48           ` Filipe Brandenburger
2014-09-17 14:28           ` Andy Lutomirski
2014-09-19 19:27             ` Andy Lutomirski
2014-09-19 21:26               ` Richard Larocque
2014-09-19 22:02               ` Filipe Brandenburger
2014-09-19 22:09                 ` Andy Lutomirski
2014-09-19 22:19                   ` Filipe Brandenburger
2014-09-19 22:31                     ` Andy Lutomirski
2014-09-20  3:10                       ` Filipe Brandenburger
2014-09-20  3:27                         ` Andy Lutomirski
2014-09-20  3:46                           ` Filipe Brandenburger
2014-09-20  5:30                             ` Andy Lutomirski
2014-09-17 11:36 ` Kevin Easton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140917113646.GA14001@chicago.guarana.org \
    --to=kevin@guarana.org \
    --cc=filbranden@google.com \
    --cc=gthelen@google.com \
    --cc=hpa@zytor.com \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=md@google.com \
    --cc=mingo@redhat.com \
    --cc=rlarocque@google.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®