From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932238AbaIQWgn (ORCPT ); Wed, 17 Sep 2014 18:36:43 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:47497 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756570AbaIQWgl (ORCPT ); Wed, 17 Sep 2014 18:36:41 -0400 Date: Thu, 18 Sep 2014 00:36:33 +0200 From: Peter Zijlstra To: Steven Rostedt Cc: Jan Kara , Markus Trippelsdorf , Geert Uytterhoeven , "linux-kernel@vger.kernel.org" , Andrew Morton Subject: Re: [PATCH] printk: git rid of [sched_delayed] message for printk_deferred Message-ID: <20140917223633.GE2848@worktop.localdomain> References: <20140915163740.GA12408@x4> <20140916105547.GA1205@quack.suse.cz> <20140916144252.GB32118@x4> <20140916111331.14303381@gandalf.local.home> <20140916203510.GF1205@quack.suse.cz> <20140916170709.73ef2993@gandalf.local.home> <20140916212250.GI1205@quack.suse.cz> <20140916173328.6306a5c2@gandalf.local.home> <20140917141816.GO2840@worktop.localdomain> <20140917102255.5cd03071@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140917102255.5cd03071@gandalf.local.home> User-Agent: Mutt/1.5.22.1 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 17, 2014 at 10:22:55AM -0400, Steven Rostedt wrote: > On Wed, 17 Sep 2014 16:18:16 +0200 > Peter Zijlstra wrote: > > By not calling console_unlock() the messages will be 'delayed', as in, > > we'll not call console->write() and we'll not see them, etc.. > > > > So some form of [delayed] or whatnot seems to remain appropriate. > > > > I agree that the 'sched_' part has lived far beyond its relevance. > > But then we should add '[delayed]' if a CPU calls printk() while > another CPU is printing, as printk() wont block in that case either, > and the output will happen some later time. You're over thinking this. You cannot (and we don't want to) know if it indeed got delayed, therefore it got delayed.