From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757541AbaIRDdw (ORCPT ); Wed, 17 Sep 2014 23:33:52 -0400 Received: from mail-bl2on0144.outbound.protection.outlook.com ([65.55.169.144]:51756 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757263AbaIRDdv (ORCPT ); Wed, 17 Sep 2014 23:33:51 -0400 Date: Thu, 18 Sep 2014 11:07:24 +0800 From: Dong Aisheng To: Pankaj Dubey CC: "'Arnd Bergmann'" , , , , , , , , , , , , Subject: Re: [PATCH v3] mfd: syscon: Decouple syscon interface from platform devices Message-ID: <20140918030722.GB26661@shlinux1.ap.freescale.net> References: <1410935510-1567-1-git-send-email-pankaj.dubey@samsung.com> <201409171723.04549.arnd@arndb.de> <000001cfd2f0$c9d0ebd0$5d72c370$@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <000001cfd2f0$c9d0ebd0$5d72c370$@samsung.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:192.88.168.50;CTRY:US;IPV:CAL;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(51704005)(164054003)(199003)(24454002)(189002)(102836001)(104016003)(33656002)(90102001)(80022003)(110136001)(76482002)(26826002)(95666004)(106466001)(105606002)(50466002)(97736003)(107046002)(46406003)(74502003)(79102003)(46102003)(74662003)(81342003)(77982003)(81542003)(31966008)(83506001)(64706001)(84676001)(85852003)(47776003)(20776003)(50986999)(92566001)(99396002)(83072002)(76176999)(85306004)(68736004)(92726001)(21056001)(83322001)(54356999)(4396001)(97756001)(6806004)(19580395003)(44976005)(19580405001)(23726002)(87936001)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR0301MB0634;H:tx30smr01.am.freescale.net;FPR:;MLV:ovrnspm;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:;UriScan:; X-Forefront-PRVS: 033857D0BD Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=Aisheng.Dong@freescale.com; X-OriginatorOrg: freescale.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 18, 2014 at 08:59:32AM +0530, Pankaj Dubey wrote: > +CC: Dong Aisheng > > Hi Arnd, > > On Wednesday, September 17, 2014, Arnd Bergmann wrote, > > > V2 of this patchset and related discussion can be found here [1]. > > > > > > Changes since v2: > > > - Added back platform device support from syscon, with one change that > > > syscon will not be probed for DT based platform. > > > - Added back syscon_regmap_lookup_by_pdevname API so that non-DT base > > > users of syscon will not be broken. > > > - Removed unwanted change in syscon.h. > > > - Modified Signed-off-by list, added Suggested-by of Tomasz Figa and > > > Arnd Bergmann. > > > - Added Tested-by of Vivek Gautam for testing on Exynos platform. > > > > Looks fine. Provided you can figure out the problem that Dong Aisheng > reported, > > please add my > > > > Acked-by: Arnd Bergmann > > > > Thanks. > After he reported I have again done code walk-through of regmap_init_mmio > and > could not see any such fatal error. At the same time I have replied to Dong > Aisheng, > asking for more details and waiting for his reply. > I just replied and gave the log. Regards Dong Aisheng > > > -} > > > +static struct syscon *of_syscon_register(struct device_node *np); > > > > > > > One minor comment: please avoid doing forward declarations of local > functions. It > > took me a while to understand what is going on because I expect all > functions to be > > ordered such that they only get called by functions below, and don't need > this. > > > > Just move of_syscon_register() here directly. > > > > OK, I will remove forward declaration of "of_syscon_register" and respin > patch once again. > > > Arnd > > Thanks, > Pankaj Dubey >