From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756791AbaIRKZL (ORCPT ); Thu, 18 Sep 2014 06:25:11 -0400 Received: from mga01.intel.com ([192.55.52.88]:45529 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755755AbaIRKZJ (ORCPT ); Thu, 18 Sep 2014 06:25:09 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,546,1406617200"; d="scan'208";a="593174299" Date: Thu, 18 Sep 2014 13:25:05 +0300 From: Heikki Krogerus To: Kishon Vijay Abraham I Cc: Greg Kroah-Hartman , Felipe Balbi , Vivek Gautam , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH 2/6] phy: improved lookup method Message-ID: <20140918102505.GB8567@xps8300> References: <1408620803-10464-1-git-send-email-heikki.krogerus@linux.intel.com> <1408620803-10464-3-git-send-email-heikki.krogerus@linux.intel.com> <5411C0B2.3060505@ti.com> <20140912140720.GC30816@xps8300> <54130729.5010206@ti.com> <20140915123508.GA16653@xps8300> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140915123508.GA16653@xps8300> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 15, 2014 at 03:35:08PM +0300, Heikki Krogerus wrote: > On Fri, Sep 12, 2014 at 08:16:01PM +0530, Kishon Vijay Abraham I wrote: > > Assume you have 2 phys in your system.. > > static struct phy_lookup usb_lookup = { > > .phy_name = "phy-usb.0", > > .dev_id = "usb.0", > > .con_id = "usb", > > }; > > > > static struct phy_lookup sata_lookup = { > > .phy_name = "sata-usb.1", > > .dev_id = "sata.0", > > .con_id = "sata", > > }; > > > > First you do modprobe phy-usb, the probe of USB PHY driver gets invoked and it > > creates the PHY. The phy-core will find a free id (now it will be 0) and then > > name the phy as phy-usb.0. > > Then with modprobe phy-sata, the phy-core will create phy-sata.1. > > > > This is an ideal case where the .phy_name in phy_lookup matches. > > > > Consider if the order is flipped and the user does modprobe phy-sata first. The > > phy_names won't match anymore (the sata phy device name would be "sata-usb.0"). Actually, I don't think there would be this problem if we used the name of the actual device which is the parent of phy devices, right? Cheers, -- heikki