mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Zefan Li <lizefan@huawei.com>
Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
	mingo@redhat.com, tj@kernel.org, akpm@linux-foundation.org,
	cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
	fernando_b1@lab.ntt.co.jp, keescook@chromium.org
Subject: Re: Racy manipulation of task_struct->flags in cgroups code causes hard to reproduce kernel panics
Date: Sat, 20 Sep 2014 16:30:12 +0200	[thread overview]
Message-ID: <20140920143012.GL2832@worktop.localdomain> (raw)
In-Reply-To: <541D16EA.70407@huawei.com>

On Sat, Sep 20, 2014 at 01:55:54PM +0800, Zefan Li wrote:
> We should make the updating of this flag atomic.

>  /* Per-process atomic flags. */
>  #define PFA_NO_NEW_PRIVS 0x00000001	/* May not gain new privileges. */
> +#define PFA_SPREAD_PAGE  0x00000002	/* Spread page cache over cpuset */
> +#define PFA_SPREAD_SLAB  0x00000004	/* Spread some slab caches over cpuset */

Ooh, I was not ware we had those.. /me checks where that came from. Hmm
weird, while I did get that patch it had a seccomp prefix when landing
in my inbox so I ignored it. However the commit has a sched prefix
(which I would not have ignored). Dubious things happened here.



  parent reply	other threads:[~2014-09-20 14:30 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-19 11:53 Tetsuo Handa
2014-09-19 22:21 ` Peter Zijlstra
2014-09-20  5:55 ` Zefan Li
2014-09-20 10:40   ` [PATCH 3.17-rc5] Fix confusing PFA_NO_NEW_PRIVS constant Tetsuo Handa
2014-09-20 17:19     ` Kees Cook
2014-09-20 14:30   ` Peter Zijlstra [this message]
2014-09-20 17:15     ` Racy manipulation of task_struct->flags in cgroups code causes hard to reproduce kernel panics Kees Cook
2014-09-20 18:04       ` Peter Zijlstra
2014-09-20 17:28   ` Tejun Heo
2014-09-21  5:15     ` Tetsuo Handa
2014-09-22  2:15       ` Zefan Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140920143012.GL2832@worktop.localdomain \
    --to=peterz@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=cgroups@vger.kernel.org \
    --cc=fernando_b1@lab.ntt.co.jp \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=mingo@redhat.com \
    --cc=penguin-kernel@I-love.SAKURA.ne.jp \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome