From: Peter Zijlstra <peterz@infradead.org>
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: linux-kernel@vger.kernel.org, Tejun Heo <tj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
"David S. Miller" <davem@davemloft.net>,
Ingo Molnar <mingo@kernel.org>, Kees Cook <keescook@chromium.org>,
Francesco Fusco <ffusco@redhat.com>,
Greg Thelen <gthelen@google.com>,
Chris Wilson <chris@chris-wilson.co.uk>,
Randy Dunlap <rdunlap@infradead.org>,
George Spelvin <linux@horizon.com>,
Mark Salter <msalter@redhat.com>
Subject: Re: [PATCH] lib: remove prio_heap
Date: Mon, 22 Sep 2014 13:31:33 +0200 [thread overview]
Message-ID: <20140922113133.GB2832@worktop.localdomain> (raw)
In-Reply-To: <1411373687-11873-1-git-send-email-laijs@cn.fujitsu.com>
On Mon, Sep 22, 2014 at 04:14:35PM +0800, Lai Jiangshan wrote:
> The prio_heap was unused since 889ed9ceaa97 ("cgroup: remove css_scan_tasks()"),
> it should be compiled-out for shrinking the binary kernel size which can be
> done via introducing CONFIG_PRIO_HEAD or via removing the code.
>
> But we can simply recover the code from the git quickly when needed,
> so it would be better to remove it IMO.
>
Sounds like a wonderful cleanup, that code always gave me head-aches :-)
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
next prev parent reply other threads:[~2014-09-22 11:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-22 8:14 Lai Jiangshan
2014-09-22 11:31 ` Peter Zijlstra [this message]
2014-09-23 14:25 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140922113133.GB2832@worktop.localdomain \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=chris@chris-wilson.co.uk \
--cc=davem@davemloft.net \
--cc=ffusco@redhat.com \
--cc=gthelen@google.com \
--cc=keescook@chromium.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@horizon.com \
--cc=mingo@kernel.org \
--cc=msalter@redhat.com \
--cc=rdunlap@infradead.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®