From: Julien Cristau <jcristau@debian.org>
To: Josh Boyer <jwboyer@fedoraproject.org>
Cc: Thomas Hellstrom <thellstrom@vmware.com>,
David Airlie <airlied@linux.ie>,
dmarlin@redhat.com, Brian Paul <brianp@vmware.com>,
"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
DRI mailing list <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm/vmwgfx: Fix drm.h include
Date: Mon, 22 Sep 2014 21:58:17 +0200 [thread overview]
Message-ID: <20140922195817.GV10640@betterave.cristau.org> (raw)
In-Reply-To: <CA+5PVA5t5Q3gRPaHebM7npfKLpET7xm70DXDWMbV0L0nsviBvQ@mail.gmail.com>
On Tue, Sep 16, 2014 at 09:43:50 -0400, Josh Boyer wrote:
> On Fri, Sep 5, 2014 at 1:19 PM, Josh Boyer <jwboyer@fedoraproject.org> wrote:
> > The userspace drm.h include doesn't prefix the drm directory. This can lead
> > to compile failures as /usr/include/drm/ isn't in the standard gcc include
> > paths. Fix it to be <drm/drm.h>, which matches the rest of the driver drm
> > header files that get installed into /usr/include/drm.
> >
> > Red Hat Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1138759
> >
> > Fixes: 1d7a5cbf8f74e
> > Reported-by: Jeffrey Bastian <jbastian@redhat.com>
> > Signed-off-by: Josh Boyer <jwboyer@fedoraproject.org>
>
> Ping? Did this get queued anywhere?
>
Any reason this doesn't just #include "drm.h"? That should work whether
the drm headers are installed in /usr/include/drm/ or
/usr/include/libdrm/...
Cheers,
Julien, who doesn't have a /usr/include/drm/ either
prev parent reply other threads:[~2014-09-22 20:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-05 17:19 Josh Boyer
2014-09-08 12:01 ` Emil Velikov
2014-09-08 12:14 ` Josh Boyer
2014-09-08 12:26 ` Emil Velikov
2014-09-08 12:15 ` Thomas Hellstrom
2014-09-08 12:42 ` Emil Velikov
2014-09-16 13:43 ` Josh Boyer
2014-09-17 0:03 ` Dave Airlie
2014-09-22 19:58 ` Julien Cristau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140922195817.GV10640@betterave.cristau.org \
--to=jcristau@debian.org \
--cc=airlied@linux.ie \
--cc=brianp@vmware.com \
--cc=dmarlin@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jwboyer@fedoraproject.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thellstrom@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®