From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754438AbaIWH0S (ORCPT ); Tue, 23 Sep 2014 03:26:18 -0400 Received: from mx2.parallels.com ([199.115.105.18]:48435 "EHLO mx2.parallels.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751693AbaIWH0R (ORCPT ); Tue, 23 Sep 2014 03:26:17 -0400 Date: Tue, 23 Sep 2014 11:26:00 +0400 From: Vladimir Davydov To: Johannes Weiner CC: Andrew Morton , , , Michal Hocko , Christoph Lameter Subject: Re: [PATCH 2/2] memcg: move memcg_update_cache_size to slab_common.c Message-ID: <20140923072600.GB3588@esperanza> References: <0689062e28e13375241dcc64df2a398c9d606c64.1411054735.git.vdavydov@parallels.com> <20140922201137.GB5373@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20140922201137.GB5373@cmpxchg.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 22, 2014 at 04:11:37PM -0400, Johannes Weiner wrote: > On Thu, Sep 18, 2014 at 07:50:20PM +0400, Vladimir Davydov wrote: > > @@ -646,11 +646,13 @@ int memcg_limited_groups_array_size; > > struct static_key memcg_kmem_enabled_key; > > EXPORT_SYMBOL(memcg_kmem_enabled_key); > > > > +static void memcg_free_cache_id(int id); > > Any chance you could re-order this code to avoid the forward decl? I'm going to move the call to memcg_free_cache_id() from the css free path to css offline. Actually, this is what "[PATCH -mm 08/14] memcg: release memcg_cache_id on css offline", which is a part of my "Per memcg slab shrinkers" patch set, does. The css offline path is defined below css_alloc/free_cache_id, so the forward declaration will be removed then. Thanks, Vladimir