From: Andrew Morton <akpm@linux-foundation.org>
To: Peter Foley <pefoley2@pefoley.com>
Cc: ashutosh dixit <ashutosh.dixit@intel.com>,
Randy Dunlap <rdunlap@infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"Dutt, Sudeep" <sudeep.dutt@intel.com>,
"Rao, Nikhil" <nikhil.rao@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH linux-next] Documentation: mic: mpssd: Disable mpssd builds for kernels < 3.13
Date: Tue, 23 Sep 2014 17:51:37 -0700 [thread overview]
Message-ID: <20140923175137.aa87c1ea.akpm@linux-foundation.org> (raw)
In-Reply-To: <CAOFdcFMiqS6-QFUo-QbwroOMmXnUL5mJd=Pjei_RjT3mhO8P5g@mail.gmail.com>
On Tue, 23 Sep 2014 19:47:11 -0400 Peter Foley <pefoley2@pefoley.com> wrote:
> On Tue, Sep 23, 2014 at 7:38 PM, Andrew Morton
> <akpm@linux-foundation.org> wrote:
> > This build error is caused by compiling mpssd prior to `make
> > headers_install'.
> >
> > There's really no reason to check the kernel version. If someone
> > transplants mpssd out of its distributed kernel and into some older
> > kernel then a miscompile is their problem - their backport is
> > incomplete.
>
> I've only noticed this error when running make Documentation/,
> in which case gcc silently uses the headers from the system,
> since the headers_install ones don't exist yet.
>
> Maybe having the build error out in this case instead of having mysterious
> compile errors would be a better solution?
>
Can't we just fix the Makefiles? Cook up a rule which makes
headers_install (if needed) before building Documentation/?
next prev parent reply other threads:[~2014-09-24 0:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-23 21:55 Ashutosh Dixit
2014-09-23 21:46 ` Randy Dunlap
2014-09-23 22:59 ` ashutosh dixit
2014-09-23 23:23 ` Peter Foley
2014-09-23 23:38 ` Andrew Morton
2014-09-23 23:47 ` Peter Foley
2014-09-24 0:51 ` Andrew Morton [this message]
2014-09-24 0:58 ` Peter Foley
2014-09-24 4:51 ` ashutosh dixit
2014-09-24 4:59 ` Andrew Morton
2014-09-24 5:20 ` ashutosh dixit
2014-09-23 21:59 ` Peter Foley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140923175137.aa87c1ea.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ashutosh.dixit@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikhil.rao@intel.com \
--cc=pefoley2@pefoley.com \
--cc=rdunlap@infradead.org \
--cc=sudeep.dutt@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome