From: Jeff Layton <jeff.layton@primarydata.com>
To: NeilBrown <neilb@suse.de>
Cc: Trond Myklebust <trond.myklebust@primarydata.com>,
linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, Ingo Molnar <mingo@redhat.com>,
linux-fsdevel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Jeff Layton <jeff.layton@primarydata.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH 0/5] Remove possible deadlocks in nfs_release_page() - V3
Date: Wed, 24 Sep 2014 07:27:01 -0400 [thread overview]
Message-ID: <20140924072701.49a70346@tlielax.poochiereds.net> (raw)
In-Reply-To: <20140924012422.4838.29188.stgit@notabene.brown>
On Wed, 24 Sep 2014 11:28:32 +1000
NeilBrown <neilb@suse.de> wrote:
> This set includes acked-by's from Andrew and Peter so it should be
> OK for all five patches to go upstream through the NFS tree.
>
> I split the congestion tracking patch out from the wait-for-PG_private
> patch as they are conceptually separate.
>
> This set continues to perform well in my tests and addresses all
> issues that have been raised.
>
> Thanks a lot,
> NeilBrown
>
>
> ---
>
> NeilBrown (5):
> SCHED: add some "wait..on_bit...timeout()" interfaces.
> MM: export page_wakeup functions
> NFS: avoid deadlocks with loop-back mounted NFS filesystems.
> NFS: avoid waiting at all in nfs_release_page when congested.
> NFS/SUNRPC: Remove other deadlock-avoidance mechanisms in nfs_release_page()
>
>
> fs/nfs/file.c | 29 +++++++++++++++++++----------
> fs/nfs/write.c | 7 +++++++
> include/linux/pagemap.h | 12 ++++++++++--
> include/linux/wait.h | 5 ++++-
> kernel/sched/wait.c | 36 ++++++++++++++++++++++++++++++++++++
> mm/filemap.c | 21 +++++++++++++++------
> net/sunrpc/sched.c | 2 --
> net/sunrpc/xprtrdma/transport.c | 2 --
> net/sunrpc/xprtsock.c | 10 ----------
> 9 files changed, 91 insertions(+), 33 deletions(-)
>
Cool!
This looks like it'll address my earlier concern about setting the BDI
congested inappropriately. You can add this to the set if you like:
Acked-by: Jeff Layton <jlayton@primarydata.com>
prev parent reply other threads:[~2014-09-24 11:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-24 1:28 NeilBrown
2014-09-24 1:28 ` [PATCH 2/5] MM: export page_wakeup functions NeilBrown
2014-09-24 1:28 ` [PATCH 3/5] NFS: avoid deadlocks with loop-back mounted NFS filesystems NeilBrown
2014-09-24 1:28 ` [PATCH 5/5] NFS/SUNRPC: Remove other deadlock-avoidance mechanisms in nfs_release_page() NeilBrown
2014-09-24 1:28 ` [PATCH 4/5] NFS: avoid waiting at all in nfs_release_page when congested NeilBrown
2014-09-24 1:28 ` [PATCH 1/5] SCHED: add some "wait..on_bit...timeout()" interfaces NeilBrown
2014-09-24 7:04 ` Ingo Molnar
2014-09-25 3:23 ` NeilBrown
2014-09-25 3:28 ` Trond Myklebust
2014-09-25 3:55 ` [PATCH 1/5 - resend] " NeilBrown
2014-09-25 5:01 ` Ingo Molnar
2014-09-24 2:06 ` [PATCH 0/5] Remove possible deadlocks in nfs_release_page() - V3 Trond Myklebust
2014-09-24 11:27 ` Jeff Layton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140924072701.49a70346@tlielax.poochiereds.net \
--to=jeff.layton@primarydata.com \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=neilb@suse.de \
--cc=peterz@infradead.org \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®