From: Lee Jones <lee.jones@linaro.org>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: sameo@linux.intel.com, patches@opensource.wolfsonmicro.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] mfd: arizona: Correct mask to allow setting micbias external cap
Date: Wed, 24 Sep 2014 12:58:14 +0100 [thread overview]
Message-ID: <20140924115813.GN19999@lee--X1> (raw)
In-Reply-To: <1411551431-13045-2-git-send-email-ckeepax@opensource.wolfsonmicro.com>
On Wed, 24 Sep 2014, Charles Keepax wrote:
> Currently the mask for the external capacitor bit is missing when
> writing the MICBIAS config meaning it will never be set this patch fixes
> this.
>
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> ---
> drivers/mfd/arizona-core.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
Applied, thanks.
> diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
> index 72b3202..bce7c07 100644
> --- a/drivers/mfd/arizona-core.c
> +++ b/drivers/mfd/arizona-core.c
> @@ -947,6 +947,7 @@ int arizona_dev_init(struct arizona *arizona)
> regmap_update_bits(arizona->regmap,
> ARIZONA_MIC_BIAS_CTRL_1 + i,
> ARIZONA_MICB1_LVL_MASK |
> + ARIZONA_MICB1_EXT_CAP |
> ARIZONA_MICB1_DISCH |
> ARIZONA_MICB1_BYPASS |
> ARIZONA_MICB1_RATE, val);
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-09-24 11:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-24 9:37 [PATCH 1/2] Revert "mfd: wm5102: Manually apply register patch" Charles Keepax
2014-09-24 9:37 ` [PATCH 2/2] mfd: arizona: Correct mask to allow setting micbias external cap Charles Keepax
2014-09-24 11:58 ` Lee Jones [this message]
2014-09-24 11:57 ` [PATCH 1/2] Revert "mfd: wm5102: Manually apply register patch" Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140924115813.GN19999@lee--X1 \
--to=lee.jones@linaro.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®