From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753156AbaIXQaM (ORCPT ); Wed, 24 Sep 2014 12:30:12 -0400 Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.226]:28666 "EHLO cdptpa-oedge-vip.email.rr.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751301AbaIXQaK (ORCPT ); Wed, 24 Sep 2014 12:30:10 -0400 Date: Wed, 24 Sep 2014 12:30:07 -0400 From: Steven Rostedt To: Shuah Khan Cc: Masami Hiramatsu , LKML , Namhyung Kim , Shuah Khan , Tom Zanussi , Oleg Nesterov , Fengguang Wu , Ingo Molnar Subject: Re: [RFC][PATCH] ftracetest: Add a couple of ftrace test cases Message-ID: <20140924123007.7fcb0099@gandalf.local.home> In-Reply-To: <5422EFB4.2050104@osg.samsung.com> References: <20140923173846.603cb49c@gandalf.local.home> <5422336A.6030304@hitachi.com> <20140924114235.4287f4a1@gandalf.local.home> <20140924115811.6eeeab8c@gandalf.local.home> <5422EAE2.6080005@osg.samsung.com> <20140924120853.0a717b7e@gandalf.local.home> <5422EFB4.2050104@osg.samsung.com> X-Mailer: Claws Mail 3.10.1 (GTK+ 2.24.24; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-RR-Connecting-IP: 107.14.168.118:25 X-Cloudmark-Score: 0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 24 Sep 2014 10:22:12 -0600 Shuah Khan wrote: > One simple approach is to have the user install the required tools > for the test. Indicate what is needed and fail the test with > appropriate message with xskip. This is what I have in mind for > tests that can't be run because of a missing config. The same can > be extended to external tools that the test depends on. Should I hold off adding my tests until we have all this in place. Or should I just push my tests with simply passing if the config isn't supported for now and add it later? I wont add any of the tests that require other tools besides echo, grep and cat. -- Steve