mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Jan Kara <jack@suse.cz>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	Heinrich Schuchardt <xypron.debian@gmx.de>,
	"Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	John McCutchan <john@johnmccutchan.com>,
	Robert Love <rlove@rlove.org>, Eric Paris <eparis@parisplace.org>,
	Cyrill Gorcunov <gorcunov@openvz.org>,
	Pavel Emelyanov <xemul@parallels.com>,
	Andrey Vagin <avagin@openvz.org>
Subject: Re: [PATCH] fs: don't remove inotify watchers from alive inode-s (v2)
Date: Wed, 24 Sep 2014 13:19:47 -0700	[thread overview]
Message-ID: <20140924131947.bc083e7f34981bbf73a364f1@linux-foundation.org> (raw)
In-Reply-To: <20140924105155.GA24411@quack.suse.cz>

On Wed, 24 Sep 2014 12:51:55 +0200 Jan Kara <jack@suse.cz> wrote:

>   Hello,
> 
>   Andrew, what do you think about the patch below? Al objected that it
> changes userspace visible behavior some time ago and then he didn't react
> to our explanations...

Difficult situation.  There's some really important information missing
from the changelog:

- Who cares?  Is there some real application which is hurting from
  the current situation?  If so, who, what, how and why.  If not, then
  why change anything?

- A description of the userspace API change impact.  How did the
  interface change?  What is the risk of this change causing damage to
  real applications?

If we can answer these questions then we're in a position to make the
pain-versus-gain tradeoff decision.


  reply	other threads:[~2014-09-24 20:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-19 15:45 Andrey Vagin
2014-09-19 15:56 ` [PATCH] inotify.7: describe ambiguous behaviour of IN_DELETE_SELF Andrey Vagin
2014-09-19 16:15 ` [PATCH] fs: don't remove inotify watchers from alive inode-s (v2) Cyrill Gorcunov
2014-09-24 10:51 ` Jan Kara
2014-09-24 20:19   ` Andrew Morton [this message]
2014-09-25  8:30     ` Jan Kara
2014-09-25 20:38       ` Cyrill Gorcunov
2014-10-02 10:45       ` Jan Kara
2014-10-02 19:44         ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140924131947.bc083e7f34981bbf73a364f1@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=avagin@openvz.org \
    --cc=eparis@parisplace.org \
    --cc=gorcunov@openvz.org \
    --cc=jack@suse.cz \
    --cc=john@johnmccutchan.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mtk.manpages@gmail.com \
    --cc=rlove@rlove.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=xemul@parallels.com \
    --cc=xypron.debian@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome