From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754001AbaIXNfU (ORCPT ); Wed, 24 Sep 2014 09:35:20 -0400 Received: from mail-qc0-f181.google.com ([209.85.216.181]:33532 "EHLO mail-qc0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753967AbaIXNfS (ORCPT ); Wed, 24 Sep 2014 09:35:18 -0400 Date: Wed, 24 Sep 2014 09:35:13 -0400 From: Tejun Heo To: Zefan Li Cc: Peter Zijlstra , Ingo Molnar , Kees Cook , Miao Xie , Tetsuo Handa , LKML , Cgroups , David Rientjes Subject: Re: [PATCH v3 1/3] sched: fix confusing PFA_NO_NEW_PRIVS constant Message-ID: <20140924133513.GD16555@htj.dyndns.org> References: <542124D3.9000007@huawei.com> <20140924132218.GC16555@htj.dyndns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140924132218.GC16555@htj.dyndns.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 24, 2014 at 09:22:18AM -0400, Tejun Heo wrote: > On Tue, Sep 23, 2014 at 03:44:19PM +0800, Zefan Li wrote: > > From: Tetsuo Handa > > > > Commit 1d4457f99928 ("sched: move no_new_privs into new atomic flags") > > defined PFA_NO_NEW_PRIVS as hexadecimal value, but it is confusing > > because it is used as bit number. Redefine it as decimal bit number. > > > > Note this changes the bit position of PFA_NOW_NEW_PRIVS from 1 to 0. > > > > Cc: Peter Zijlstra > > Cc: Ingo Molnar > > Cc: Miao Xie > > Cc: Kees Cook > > Signed-off-by: Tetsuo Handa > > Acked-by: Kees Cook > > [ lizf: slightly modified subject and changelog ] > > Signed-off-by: Zefan Li > > Applied 1-3 to cgroup/for-3.17-fixes w/ the typo spotted by davidr > fixed. Reverted due to build failure. Will wait for a refreshed version. :( Thanks. -- tejun