From: Andrew Morton <akpm@linux-foundation.org>
To: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Cc: <linux-kernel@vger.kernel.org>, Will Deacon <will.deacon@arm.com>,
Olof Johansson <olof@lixom.net>,
Catalin Marinas <catalin.marinas@arm.com>
Subject: Re: [PATCH] genalloc: fix device node resource counter
Date: Wed, 24 Sep 2014 13:58:31 -0700 [thread overview]
Message-ID: <20140924135831.ec76a8c60294a93e2da3b7af@linux-foundation.org> (raw)
In-Reply-To: <1411588260-29825-1-git-send-email-vladimir_zapolskiy@mentor.com>
On Wed, 24 Sep 2014 22:51:00 +0300 Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> wrote:
> The change balances a usage counter of np_pool device_node, which is
> incremented on preceding of_parse_phandle() call.
>
> ...
>
> --- a/lib/genalloc.c
> +++ b/lib/genalloc.c
> @@ -637,6 +637,7 @@ struct gen_pool *of_get_named_gen_pool(struct device_node *np,
> if (!np_pool)
> return NULL;
> pdev = of_find_device_by_node(np_pool);
> + of_node_put(np_pool);
> if (!pdev)
> return NULL;
> return dev_get_gen_pool(&pdev->dev);
Looks good, thanks.
However... when fixing a bug, please always describe the end-user
visible effects of that bug. Amongst other things this is to help me
and others decide which kernel version(s) need the patch.
I'm assuming that the effect will be, at worst, a memory leak at the
rate of one device_node per hot-unplug event and is hence a very minor
thing?
next prev parent reply other threads:[~2014-09-24 20:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-24 19:51 Vladimir Zapolskiy
2014-09-24 20:58 ` Andrew Morton [this message]
2014-09-25 11:04 ` Vladimir Zapolskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140924135831.ec76a8c60294a93e2da3b7af@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=vladimir_zapolskiy@mentor.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome