mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: Hugh Dickins <hughd@google.com>,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] shmem: fix nlink for rename overwrite directory
Date: Wed, 24 Sep 2014 19:58:49 +0100	[thread overview]
Message-ID: <20140924185849.GD7996@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20140924155617.GD7441@tucsk.piliscsaba.szeredi.hu>

On Wed, Sep 24, 2014 at 05:56:17PM +0200, Miklos Szeredi wrote:
> From: Miklos Szeredi <mszeredi@suse.cz>
> 
> If overwriting an empty directory with rename, then need to drop the extra
> nlink.

Hmm...  OK, point.  It doesn't actually check for ->i_nlink for directories,
and it only affects the sucker while it (a directory) is opened-but-rmdired,
but yes, it's visible to userland, so...  Applied.

  reply	other threads:[~2014-09-24 18:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-24 15:56 Miklos Szeredi
2014-09-24 18:58 ` Al Viro [this message]
2014-09-27  6:33 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140924185849.GD7996@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=hughd@google.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome