From: Michael Ellerman <mpe@ellerman.id.au>
To: Pranith Kumar <bobby.prani@gmail.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Cc: Andew Morton <akpm@linux-foundation.org>
Subject: Re: powerpc: Fix build failure when MEMORY_HOTPLUG=y
Date: Thu, 25 Sep 2014 11:14:09 +1000 (EST) [thread overview]
Message-ID: <20140925011409.F1A20140143@ozlabs.org> (raw)
In-Reply-To: <1408482065-18457-1-git-send-email-bobby.prani@gmail.com>
On Tue, 2014-19-08 at 21:01:05 UTC, Pranith Kumar wrote:
> ARCH_ENABLE_MEMORY_HOTPLUG is enabled by default for powerpc. This causes build
> failures when SPARSEMEM=n as memory hotplug needs definition which are defined
> only when SPARSEMEM=y. The error is as follows:
> arch/powerpc/platforms/pseries/hotplug-memory.c:27:31: error: 'SECTION_SIZE_BITS' undeclared (first use in this function)
> arch/powerpc/platforms/pseries/hotplug-memory.c:27:31: note: each undeclared identifier is reported only once for each function it appears in
I don't see how you can even build pseries without SPARSEMEM=y ?
The three options are:
default DISCONTIGMEM_MANUAL if ARCH_DISCONTIGMEM_DEFAULT
default SPARSEMEM_MANUAL if ARCH_SPARSEMEM_DEFAULT
default FLATMEM_MANUAL
We don't have DISCONTIGMEM.
FLATMEM_MANUAL depends on !ARCH_SPARSEMEM_ENABLE.
We turn on ARCH_SPARSEMEM_ENABLE, and it's not user editable.
cheers
prev parent reply other threads:[~2014-09-25 1:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-19 21:01 [PATCH] " Pranith Kumar
2014-08-20 8:00 ` Geert Uytterhoeven
2014-08-20 13:12 ` Pranith Kumar
2014-09-25 1:14 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140925011409.F1A20140143@ozlabs.org \
--to=mpe@ellerman.id.au \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=bobby.prani@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®