From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Mike Roocroft <mike.linux@btinternet.com>
Cc: gregkh@linuxfoundation.org, swetland@google.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] Staging: android: sw_sync: fixed a coding style issues
Date: Sat, 27 Sep 2014 20:31:47 +0530 [thread overview]
Message-ID: <20140927150147.GB2413@sudip-PC> (raw)
In-Reply-To: <1411686716-2663-1-git-send-email-mike.linux@btinternet.com>
On Fri, Sep 26, 2014 at 12:11:56AM +0100, Mike Roocroft wrote:
you forgot to write the commit message and also mention there what kind of warning you have fixed.
thanks
sudip
> Signed-off-by: Mike Roocroft <mike.linux@btinternet.com>
> ---
> drivers/staging/android/sw_sync.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/staging/android/sw_sync.c b/drivers/staging/android/sw_sync.c
> index a76db3f..863d4b1 100644
> --- a/drivers/staging/android/sw_sync.c
> +++ b/drivers/staging/android/sw_sync.c
> @@ -97,6 +97,7 @@ static void sw_sync_pt_value_str(struct sync_pt *sync_pt,
> char *str, int size)
> {
> struct sw_sync_pt *pt = (struct sw_sync_pt *)sync_pt;
> +
> snprintf(str, size, "%d", pt->value);
> }
>
> @@ -156,6 +157,7 @@ static int sw_sync_open(struct inode *inode, struct file *file)
> static int sw_sync_release(struct inode *inode, struct file *file)
> {
> struct sw_sync_timeline *obj = file->private_data;
> +
> sync_timeline_destroy(&obj->obj);
> return 0;
> }
> --
> 2.1.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2014-09-27 15:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-25 23:11 Mike Roocroft
2014-09-27 15:01 ` Sudip Mukherjee [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-09-25 23:08 Mike Roocroft
2014-09-29 2:00 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140927150147.GB2413@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.linux@btinternet.com \
--cc=swetland@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome