mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chenhui Zhao <chenhui.zhao@freescale.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: <kernel@pengutronix.de>, <linux-kernel@vger.kernel.org>,
	<Zhuoyu.Zhang@freescale.com>, <Jason.Jin@freescale.com>,
	<leoli@freescale.com>, <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/3] pm: add FSM configuration for deep sleep
Date: Sun, 28 Sep 2014 17:53:16 +0800	[thread overview]
Message-ID: <20140928095316.GA9797@udp189498uds.ap.freescale.net> (raw)
In-Reply-To: <20140926205153.GY5182@n2100.arm.linux.org.uk>

On Fri, Sep 26, 2014 at 09:51:53PM +0100, Russell King - ARM Linux wrote:
> On Fri, Sep 26, 2014 at 01:02:01PM +0100, Russell King - ARM Linux wrote:
> > On Fri, Sep 26, 2014 at 07:25:02PM +0800, Chenhui Zhao wrote:
> > > +void fsm_write32(void __iomem *addr, u32 val)
> > > +{
> > > +#ifdef __arm__
> > > +	iowrite32be(val, addr);
> > > +#endif
> > > +
> > > +#ifdef __powerpc__
> > > +	out_be32(addr, val);
> > > +#endif
> > 
> > The idea of iowrite* is that it should be able to address MMIO or IO
> > memory irrespective of the platform.  Why is PowerPC not implementing
> > this accessor, or why can't it be used for PowerPC?
> > 
> > This should just use iowrite32be(), and if it doesn't work on PowerPC,
> > PowerPC needs to be fixed.
> 
> BenH tells me that this should be able to use iowrite32be() on PowerPC
> too without problems, there should be no need to use the older out_be32()
> accessors here.  Please can you look into using only iowrite32be() here?
> 
> Thanks.
> 

Thanks. I'll fix it.

Chenhui

  reply	other threads:[~2014-09-28  9:52 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-26 11:25 [PATCH 0/3] arm: ls1: add deep sleep support Chenhui Zhao
2014-09-26 11:25 ` [PATCH 1/3] arm: ls1: add CPU hotplug platform support Chenhui Zhao
2014-09-26 12:20   ` Russell King - ARM Linux
2014-09-26 12:46     ` Mark Rutland
2014-09-26 13:03       ` Russell King - ARM Linux
2014-09-26 13:20         ` Mark Rutland
2014-09-28 10:57           ` Li Yang
2014-09-28 14:27             ` Russell King - ARM Linux
2014-09-26 11:25 ` [PATCH 2/3] pm: add FSM configuration for deep sleep Chenhui Zhao
2014-09-26 12:02   ` Russell King - ARM Linux
2014-09-26 20:51     ` Russell King - ARM Linux
2014-09-28  9:53       ` Chenhui Zhao [this message]
2014-09-26 11:25 ` [PATCH 3/3] arm: pm: add deep sleep support for LS1 Chenhui Zhao
2014-09-26 12:14   ` Russell King - ARM Linux
2014-09-28 11:06     ` Chenhui Zhao
2014-09-28 14:26       ` Russell King - ARM Linux
2014-09-29  9:42         ` Chenhui Zhao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140928095316.GA9797@udp189498uds.ap.freescale.net \
    --to=chenhui.zhao@freescale.com \
    --cc=Jason.Jin@freescale.com \
    --cc=Zhuoyu.Zhang@freescale.com \
    --cc=kernel@pengutronix.de \
    --cc=leoli@freescale.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®