From: Mark Brown <broonie@kernel.org>
To: Romain Perier <romain.perier@gmail.com>
Cc: heiko@sntech.de, linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
lgirdwood@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/3] regulator: act8865: Add support to turn off all outputs
Date: Sun, 28 Sep 2014 11:33:01 +0100 [thread overview]
Message-ID: <20140928103301.GN27755@sirena.org.uk> (raw)
In-Reply-To: <1411834906-9533-1-git-send-email-romain.perier@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 873 bytes --]
On Sat, Sep 27, 2014 at 04:21:44PM +0000, Romain Perier wrote:
> When the property "active-semi,system-power-controller" is found in the
> devicetree, the function pm_power_off is defined. This function sends the
> rights bit fields to the global off control register. shutdown/poweroff
> commands are now supported for hardware components which use these PMU.
We really need to come up with a standard property for this and document
it rather than continuing to add individual device specific properties
all doing the same thing, and probably also some helper code and/or a
standard operation for this - there's a lot of drivers implementing the
same pattern here.
> + if (dev->of_node &&
> + of_property_read_bool(dev->of_node,
> + "active-semi,system-power-controller")) {
> + act8865_i2c_client = client;
Indentation seems messed up here - tabs vs spaces?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-09-28 10:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-27 16:21 Romain Perier
2014-09-27 16:21 ` [PATCH v1 2/3] ARM: dts: rockchip: Enable power off in pmic for Radxa Rock Romain Perier
2014-09-27 16:21 ` [PATCH v1 3/3] dt-bindings: Document the property system-power-controller for act8865 regulator Romain Perier
2014-09-28 10:33 ` Mark Brown [this message]
2014-09-28 12:00 ` [PATCH v1 1/3] regulator: act8865: Add support to turn off all outputs PERIER Romain
2014-09-28 12:25 ` Mark Brown
2014-09-28 13:25 ` PERIER Romain
2014-09-28 15:04 ` PERIER Romain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140928103301.GN27755@sirena.org.uk \
--to=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=romain.perier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®